From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 63F2F385841E for ; Tue, 31 Jan 2023 11:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63F2F385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675165486; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=le8ZT+7++QMXci8paD0Z3BpMlmzLBU0mrRFuYDdV174=; b=MkpQFrIaDy4uzRBGxfZlpzvGnfo9bb+sew8/CR24TDB8STdsLYO4neJGLx2MUJBGEdQtRT FbiFwUxC/p3MgZByF0GvuFRHi5BI1qTR20UQNUzgGk7kDtzkM7YtBqNZAnDTf8hF5LA0xj D1BmamsIkVzN5vBIzo2t/gjCOG33sQg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-4gMX2bLwMaSDQqHoQHY66w-1; Tue, 31 Jan 2023 06:44:44 -0500 X-MC-Unique: 4gMX2bLwMaSDQqHoQHY66w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D477811E6E; Tue, 31 Jan 2023 11:44:44 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E686175A2; Tue, 31 Jan 2023 11:44:44 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30VBifqh1045638 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 31 Jan 2023 12:44:41 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30VBieZW1045637; Tue, 31 Jan 2023 12:44:40 +0100 Date: Tue, 31 Jan 2023 12:44:40 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] Fortran: Extend align-clause checks of OpenMP's allocate clause Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 13, 2022 at 05:38:22PM +0100, Tobias Burnus wrote: > I missed that 'align' needs to be a power of 2 - contrary to 'aligned', > which does not have this restriction for some odd reason. Yeah, odd. The C and C++ FEs indeed diagnose non-pow2p constants for align (and not for aligned clause). > > OK for mainline? Yes, thanks. Sorry for the delay. > Fortran: Extend align-clause checks of OpenMP's allocate directive > > gcc/fortran/ChangeLog: > > * openmp.cc (resolve_omp_clauses): Check also for > power of two. > > libgomp/ChangeLog: > > * testsuite/libgomp.fortran/allocate-3.f90: Fix ALIGN > usage, remove unused -fdump-tree-original. > * testsuite/libgomp.fortran/allocate-4.f90: New. Jakub