From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BB3103858D37 for ; Wed, 2 Mar 2022 17:31:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB3103858D37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-156-XSwAC0OFPzSJ73rtCMqzfw-1; Wed, 02 Mar 2022 12:31:20 -0500 X-MC-Unique: XSwAC0OFPzSJ73rtCMqzfw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF64B1091DA1; Wed, 2 Mar 2022 17:31:18 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD9EB841F5; Wed, 2 Mar 2022 17:31:17 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 222HVEG11060491 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 2 Mar 2022 18:31:14 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 222HVC0F1060490; Wed, 2 Mar 2022 18:31:12 +0100 Date: Wed, 2 Mar 2022 18:31:12 +0100 From: Jakub Jelinek To: Kwok Cheung Yeung Cc: Mikael Morin , Tobias Burnus , gscfq@t-online.de, gcc-patches , fortran Subject: Re: [PATCH][v2] openmp, fortran: Check that the type of an event handle in a detach clause is suitable [PR104131] Message-ID: Reply-To: Jakub Jelinek References: <907e1f89-4534-75e4-fdb8-a11da280e3d1@orange.fr> <65456330-dc81-0647-3bdb-6d409554136d@codesourcery.com> <14be1163-51e6-19bd-0032-c18a53ffe254@codesourcery.com> <6f75ce81-648d-a2e5-b9f4-b9aaa4a19775@orange.fr> <262035c6-7039-84c5-0b61-b9ee98f24b23@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <262035c6-7039-84c5-0b61-b9ee98f24b23@codesourcery.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 17:31:25 -0000 On Wed, Mar 02, 2022 at 05:22:21PM +0000, Kwok Cheung Yeung wrote: > I have updated the patch to catch array elements and structure components as > additional checks, in addition to checking that the variable is a scalar. > > The check has been moved to the end of resolve_omp_clauses as it is more > appropriate there. This gets rid of the additional 'Unexpected !$OMP END > TASK statement' error, since the type error is now caught after the matching > phase. > > Coarrays (with the testcases in pr104131-2.f90) can be dealt with in a > separate patch. Is this part okay for trunk? LGTM, thanks. Yes, coarrays is something that we need to deal with in all the clauses, not just this one, so before we claim OpenMP 5.0 support we need to go through it fully. Jakub