From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Tobias Burnus <tobias@codesourcery.com>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fortran: Fix up initializers of param(0) PARAMETERs [PR103691]
Date: Fri, 25 Mar 2022 12:34:25 +0100 [thread overview]
Message-ID: <Yj2owTg/uEFnlUKO@tucnak> (raw)
In-Reply-To: <CAFiYyc0kUZKVOaQNAJy2EOpaHevUjAeQZMtmdf3kOjrU_zV5KQ@mail.gmail.com>
On Fri, Mar 25, 2022 at 12:16:40PM +0100, Richard Biener wrote:
> On Fri, Mar 25, 2022 at 11:13 AM Tobias Burnus <tobias@codesourcery.com> wrote:
> >
> > On 25.03.22 09:57, Jakub Jelinek via Fortran wrote:
> > > On the gfortran.dg/pr103691.f90 testcase the Fortran ICE emits
> > > static real(kind=4) a[0] = {[0 ... -1]=2.0e+0};
> > > That is an invalid RANGE_EXPR where the maximum is smaller than the minimum.
> > >
> > > The following patch fixes that. If TYPE_MAX_VALUE is smaller than
> > > TYPE_MIN_VALUE, the array is empty and so doesn't need any initializer,
> > > if the two are equal, we don't need to bother with a RANGE_EXPR and
> > > can just use that INTEGER_CST as the index and finally for the 2+ values
> > > in the range it uses a RANGE_EXPR as before.
> > >
> > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> >
> > LGTM – thanks for taking care of Fortran patches and regressions.
> >
> > > 2022-03-25 Jakub Jelinek <jakub@redhat.com>
> > >
> > > PR fortran/103691
> > > * trans-array.cc (gfc_conv_array_initializer): If TYPE_MAX_VALUE is
> > > smaller than TYPE_MIN_VALUE (i.e. empty array), throw the initializer
> > > on the floor, if TYPE_MIN_VALUE is equal to TYPE_MAX_VALUE, use just
> > > the TYPE_MIN_VALUE as index instead of RANGE_EXPR.
> >
> > I am not sure whether "throw the initializer on the floor" is the best wording
> > for a changelog. I think I prefer a wording like "ignore the initializer" or
> > another less idiomatic expression. And I think a ';' before the second 'if'
> > also increases readability.
>
> Can there be side-effects in those initializer elements in Fortran?
For PARAMETERs certainly not, those need to be constant.
Even otherwise, this is in a routine that does
/* Create a constructor from the list of elements. */
tmp = build_constructor (type, v);
TREE_CONSTANT (tmp) = 1;
return tmp;
at the end so I wouldn't expect side-effects anywhere.
Also, I think typically in the Fortran FE side-effects would go into
se.pre and se.post sequences, not into se.expr, and this routine
doesn't emit those se.pre/se.post sequences anywhere, so presumably it
assumes they don't exist.
What is the behavior with a RANGE_EXPR when one has { [0..10] = ++i; },
is that applying the side-effects 11 times or once ?
Jakub
next prev parent reply other threads:[~2022-03-25 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 8:57 Jakub Jelinek
2022-03-25 10:13 ` Tobias Burnus
2022-03-25 11:16 ` Richard Biener
2022-03-25 11:34 ` Jakub Jelinek [this message]
2022-03-25 12:13 ` Richard Biener
2022-03-25 12:15 ` Jakub Jelinek
2022-03-26 11:27 ` Thomas Koenig
2022-03-26 17:13 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj2owTg/uEFnlUKO@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).