From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A79213857C50 for ; Tue, 5 Apr 2022 10:31:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A79213857C50 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-319-tRgJA2HENkCxvID1XPw2XA-1; Tue, 05 Apr 2022 06:31:36 -0400 X-MC-Unique: tRgJA2HENkCxvID1XPw2XA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2E13185A79C; Tue, 5 Apr 2022 10:31:35 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6425C40CF8E5; Tue, 5 Apr 2022 10:31:35 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 235AVWhd3915555 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 5 Apr 2022 12:31:33 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 235AVWbV3915553; Tue, 5 Apr 2022 12:31:32 +0200 Resent-From: Jakub Jelinek Resent-Date: Tue, 5 Apr 2022 12:31:32 +0200 Resent-Message-ID: Resent-To: Sandra Loosemore , "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Date: Sat, 26 Mar 2022 08:04:05 +0100 From: Jakub Jelinek To: Sandra Loosemore Cc: "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Fortran: Add location info to OpenMP tree nodes Message-ID: Reply-To: Jakub Jelinek References: <24bde0e8-8da4-4d4f-30fd-9a9b5830b944@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <24bde0e8-8da4-4d4f-30fd-9a9b5830b944@codesourcery.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 10:31:39 -0000 On Fri, Mar 25, 2022 at 08:03:09PM -0600, Sandra Loosemore wrote: > I've got another patch forthcoming (stage 1 material) that adds some new > diagnostics for non-rectangular loops during gimplification of OMP nodes. > When I was working on that, I discovered that the Fortran front end wasn't > attaching location information to the tree nodes corresponding to the > various OMP directives, so the new errors weren't coming out with location > info either. I went through trans-openmp.cc and fixed all the places where > make_node was being called to explicitly set the location. > > I don't have a test case specifically for this change, but my test cases for > the new diagnostics in the non-rectangular loops patch do exercise it. Is > this OK for trunk now, or for stage 1 when we get there? Ok for GCC 13. > commit 4c745003d0b39d0e92032b62421df4920753783a > Author: Sandra Loosemore > Date: Thu Mar 24 21:02:34 2022 -0700 > > Fortran: Add location info to OpenMP tree nodes > > gcc/fortran/ > * trans-openmp.cc (gfc_trans_omp_critical): Set location on OMP > tree node. > (gfc_trans_omp_do): Likewise. > (gfc_trans_omp_masked): Likewise. > (gfc_trans_omp_do_simd): Likewise. > (gfc_trans_omp_scope): Likewise. > (gfc_trans_omp_taskgroup): Likewise. > (gfc_trans_omp_taskwait): Likewise. > (gfc_trans_omp_distribute): Likewise. > (gfc_trans_omp_taskloop): Likewise. > (gfc_trans_omp_master_masked_taskloop): Likewise. Jakub