From: Jakub Jelinek <jakub@redhat.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: Fix clause splitting for OMP masked taskloop directive
Date: Sat, 26 Mar 2022 08:03:18 +0100 [thread overview]
Message-ID: <Yj66tEcw00R65A8g@tucnak> (raw)
In-Reply-To: <5061c0a0-563d-b18e-dc5e-36142ae185ec@codesourcery.com>
On Fri, Mar 25, 2022 at 08:02:04PM -0600, Sandra Loosemore wrote:
> I ran into this bug in the handling of clauses on the combined "masked
> taskloop" OMP directive when I was working on something else. The fix
> turned out to be a 1-liner. OK for trunk?
>
> -Sandra
> commit 17c4fa0bd97c070945004095a06fb7d9e91869e3
> Author: Sandra Loosemore <sandra@codesourcery.com>
> Date: Wed Mar 23 18:45:25 2022 -0700
>
> Fortran: Fix clause splitting for OMP masked taskloop directive
>
> This patch fixes an obvious coding goof that caused all clauses for
> the combined OMP masked taskloop directive to be discarded.
>
> gcc/fortran/
> * trans-openmp.cc (gfc_split_omp_clauses): Fix mask for
> EXEC_OMP_MASKED_TASKLOOP.
>
> gcc/testsuite/
> * gfortran.dg/gomp/masked-taskloop.f90: New.
Ok, thanks.
> +! { dg-final { scan-tree-dump "omp taskloop collapse\\(2\\) grainsize\\(4\\)" "original" } }
Though perhaps the test should be more flexible and allow both orderings of
the clauses and extra clauses too? So:
! { dg-final { scan-tree-dump "omp taskloop \[^\n\r]*grainsize\\(4\\)" "original" } }
! { dg-final { scan-tree-dump "omp taskloop \[^\n\r]*collapse\\(2\\)" "original" } }
?
Jakub
next prev parent reply other threads:[~2022-04-05 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 2:02 Sandra Loosemore
2022-03-26 7:03 ` Jakub Jelinek [this message]
2022-04-05 4:05 ` PING " Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj66tEcw00R65A8g@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).