From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 265DE3858D3C for ; Fri, 18 Mar 2022 13:21:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 265DE3858D3C Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-98s1EA5ONcuRUkrCR51vfg-1; Fri, 18 Mar 2022 09:21:13 -0400 X-MC-Unique: 98s1EA5ONcuRUkrCR51vfg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 42750185A794; Fri, 18 Mar 2022 13:21:13 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F29CAC3326B; Fri, 18 Mar 2022 13:21:12 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 22IDLAZZ2027315 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Mar 2022 14:21:10 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 22IDL91W2027314; Fri, 18 Mar 2022 14:21:09 +0100 Date: Fri, 18 Mar 2022 14:21:09 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] Fortran/OpenMP: Improve associate-name diagnostic [PR103039] Message-ID: Reply-To: Jakub Jelinek References: <51e942e2-b8f9-5f35-9a92-bc29e9d06bd5@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <51e942e2-b8f9-5f35-9a92-bc29e9d06bd5@codesourcery.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 13:21:20 -0000 On Fri, Mar 18, 2022 at 02:15:11PM +0100, Tobias Burnus wrote: > This patch addresses a side issue found when looking at PR103039. > > Namely instead of printing: > > 55 | !$omp parallel firstprivate(tt) > | 1 > Error: ASSOCIATE name ‘__tmp_INTEGER_4’ in FIRSTPRIVATE clause at (1) > > With the patch, the error is: > > Error: Associate name ‘tt’ in FIRSTPRIVATE clause at (1) > > That is: It prints the proper name and it uses 'associate name' > matching the Fortran standard – and takes into account that an > associate name not only used with ASSOCIATE but also with > SELECT TYPE, SELECT RANK, and (untested) CHANGE TEAMS. > > OK for mainline? LGTM, thanks. > Fortran/OpenMP: Improve associate-name diagnostic [PR103039] > > gcc/fortran/ChangeLog: > > PR fortran/103039 > * openmp.cc (resolve_omp_clauses): Improve associate-name diagnostic > for select type/rank. > > gcc/testsuite/ChangeLog: > > PR fortran/103039 > * gfortran.dg/gomp/associate1.f90: Update dg-error. > * gfortran.dg/gomp/associate2.f90: New test. > > gcc/fortran/openmp.cc | 12 +++-- > gcc/testsuite/gfortran.dg/gomp/associate1.f90 | 40 +++++++------- > gcc/testsuite/gfortran.dg/gomp/associate2.f90 | 76 +++++++++++++++++++++++++++ > 3 files changed, 104 insertions(+), 24 deletions(-) Jakub