From: Piotr Kubaj <pkubaj@anongoth.pl>
To: FX <fxcoudert@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Fortran List <fortran@gcc.gnu.org>,
segher@kernel.crashing.org
Subject: Re: [PATCH] fortran: use fpu-glibc on powerpc*-unknown-freebsd
Date: Wed, 13 Apr 2022 16:56:13 +0200 [thread overview]
Message-ID: <YlbkjYW6dxpwoC1Z@KGPE-D16> (raw)
In-Reply-To: <2E9BFB96-6979-4DB5-8029-1F89C30B242B@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On 22-03-20 16:30:08, FX wrote:
> Hi,
>
> (Please send all Fortran (front-end and libgfortran) patches in CC to the Fortran list.)
>
> Please hold from pushing the patch as is, I have some questions:
>
> - If FreeBSD has feenableexcept() and related functions, it should already use the fpu-glibc code, because of this:
>
> if test "x${have_feenableexcept}" = "xyes"; then
> fpu_host='fpu-glibc'
> ieee_support='yes'
> fi
>
> So before the patch, what was configure.host returning, and what is the value of have_feenableexcept?
>
> - Why restrict the patch to powerpc*? Don’t other FreeBSD targets have that function?
> - How does the patch affect the results of “make check-gfortran”?
>
>
> Thanks,
> FX
Hello,
the problem is that configure checks for feenableexcept() in libm:
AC_CHECK_LIB([m],[feenableexcept],[have_feenableexcept=yes AC_DEFINE([HAVE_FEENABLEEXCEPT],[1],[libm includes feenableexcept])])
FreeBSD doesn't have this function in libm, it's implemented in /usr/include/fenv.h.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-13 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 15:30 FX
2022-04-13 14:56 ` Piotr Kubaj [this message]
2022-04-13 15:27 ` FX
2022-04-14 0:49 ` Piotr Kubaj
2022-04-14 7:05 ` FX
2022-04-14 14:09 ` Piotr Kubaj
2022-04-28 17:09 ` Piotr Kubaj
2022-04-28 18:55 ` FX
2022-04-30 18:28 ` Piotr Kubaj
2022-04-30 19:17 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlbkjYW6dxpwoC1Z@KGPE-D16 \
--to=pkubaj@anongoth.pl \
--cc=fortran@gcc.gnu.org \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).