From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 125523858C2C for ; Wed, 13 Apr 2022 15:38:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 125523858C2C Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-BrevzXtUNtysd7jv_kXJ0w-1; Wed, 13 Apr 2022 11:38:18 -0400 X-MC-Unique: BrevzXtUNtysd7jv_kXJ0w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0274486B8A4; Wed, 13 Apr 2022 15:38:18 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B68541121331; Wed, 13 Apr 2022 15:38:17 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 23DFcFbd1339770 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 13 Apr 2022 17:38:15 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 23DFcESs1339769; Wed, 13 Apr 2022 17:38:14 +0200 Date: Wed, 13 Apr 2022 17:38:14 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] OpenMP/Fortran: Fix EXIT in loop diagnostic [PR105242] Message-ID: Reply-To: Jakub Jelinek References: <5d9b84e8-044c-048c-46f0-9043b6f97c23@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <5d9b84e8-044c-048c-46f0-9043b6f97c23@codesourcery.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 15:38:23 -0000 On Wed, Apr 13, 2022 at 05:16:48PM +0200, Tobias Burnus wrote: > Trivial fix – after finding the issue. The LOOP directive and > several LOOP/DO/SIMD combined directives were missing in the > check. As the PR shows, this leads to an ICE on invalid code. > > OK? > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > OpenMP/Fortran: Fix EXIT in loop diagnostic [PR105242] > > gcc/fortran/ChangeLog: > > PR fortran/105242 > * match.cc (match_exit_cycle): Handle missing OMP LOOP, DO and SIMD > directives in the EXIT/CYCLE diagnostic. > > gcc/testsuite/ChangeLog: > > PR fortran/105242 > * gfortran.dg/gomp/loop-exit.f90: New test. Ok, thanks. Jakub