From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D74E93858C53 for ; Tue, 26 Apr 2022 17:29:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D74E93858C53 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-217-ep-quUQaNgOmLCUeZoLAbQ-1; Tue, 26 Apr 2022 13:29:01 -0400 X-MC-Unique: ep-quUQaNgOmLCUeZoLAbQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A82F083395E; Tue, 26 Apr 2022 17:29:00 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EF2C2166B2F; Tue, 26 Apr 2022 17:29:00 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 23QHSvSZ1324620 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 26 Apr 2022 19:28:57 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 23QHStuR1324619; Tue, 26 Apr 2022 19:28:55 +0200 Date: Tue, 26 Apr 2022 19:28:55 +0200 From: Jakub Jelinek To: Mikael Morin Cc: Tobias Burnus , gfortran , gcc-patches , Harald Anlauf Subject: Re: [PATCH] fortran: Avoid infinite self-recursion [PR105381] Message-ID: Reply-To: Jakub Jelinek References: <8f082ce4-a6a9-72c1-a882-4663426adaff@orange.fr> <4567d0f0-3077-d582-e2d2-b0169c322009@codesourcery.com> <737d7a95-33f0-4264-4ba7-caed687c3092@orange.fr> MIME-Version: 1.0 In-Reply-To: <737d7a95-33f0-4264-4ba7-caed687c3092@orange.fr> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 17:29:06 -0000 On Tue, Apr 26, 2022 at 07:12:13PM +0200, Mikael Morin wrote: > > I think we can't in C++11/C++14. The options can be if orig_decl would be declared > > earlier, then it can be > > tree orig_decl; > > if (DECL_P (expr) > > && DECL_LANG_SPECIFIC (expr) > > && (orig_decl = GFC_DECL_SAVED_DESCRIPTOR (expr)) > > && orig_decl != expr) > > return non_negative_strides_array_p (orig_decl); > > but I think this is generally frowned upon, > > or one can repeat it like: > > if (DECL_P (expr) > > && DECL_LANG_SPECIFIC (expr) > > && GFC_DECL_SAVED_DESCRIPTOR (expr) > > && GFC_DECL_SAVED_DESCRIPTOR (expr) != expr) > > return non_negative_strides_array_p (GFC_DECL_SAVED_DESCRIPTOR (expr)); > > I think I’ll use that. There are numerous places where macros are repeated > like this already and everybody seems to be pleased with it. > Thanks for the feedback, and for the suggestions. Agreed in this case, GFC_DECL_SAVED_DESCRIPTOR is really just a dereference at least in release compiler. Doing that when the macro actually calls some functions is worse. Jakub