From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 31D35395C02A for ; Fri, 13 May 2022 17:44:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31D35395C02A Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-4wdyfg0cMNqFBME6nJ7f3g-1; Fri, 13 May 2022 13:44:55 -0400 X-MC-Unique: 4wdyfg0cMNqFBME6nJ7f3g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 570E11C05AC9; Fri, 13 May 2022 17:44:55 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 177AA14C1E82; Fri, 13 May 2022 17:44:54 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 24DHiqRa2150637 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 13 May 2022 19:44:53 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 24DHiqMT2150636; Fri, 13 May 2022 19:44:52 +0200 Date: Fri, 13 May 2022 19:44:51 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] OpenMP/Fortran: Use firstprivat not alloc for ptr attach for arrays Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 17:45:00 -0000 On Fri, May 13, 2022 at 07:21:02PM +0200, Tobias Burnus wrote: > gcc/fortran/ChangeLog: > > * trans-openmp.cc (gfc_trans_omp_clauses): When mapping nondescriptor > array sections, use GOMP_MAP_FIRSTPRIVATE_POINTER instead of > GOMP_MAP_POINTER for the pointer attachment. > > libgomp/ChangeLog: > > * testsuite/libgomp.fortran/target-nowait-array-section.f90: New test. Not 100% sure if we want to add such a testcase into the testsuite given that it is not valid OpenMP, but perhaps it is ok as we are testing a QoI. > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/target-nowait-array-section.f90 > @@ -0,0 +1,56 @@ > +! Runs the the target region asynchrolously and checks for it > +! > +! Note that map(alloc: work(:, i)) + nowait should be save s/save/safe/ Otherwise LGTM. Jakub