From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) by sourceware.org (Postfix) with ESMTPS id A35E33858CDA; Sat, 14 May 2022 05:46:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A35E33858CDA Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 7837319710B; Sat, 14 May 2022 07:46:42 +0200 (CEST) Date: Sat, 14 May 2022 07:46:41 +0200 From: Piotr Kubaj To: "Kewen.Lin" Cc: Segher Boessenkool , pkubaj@freebsd.org, gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PATCH V2] powerpc: properly check for feenableexcept() on FreeBSD Message-ID: References: <20220503102111.10406-1-pkubaj@FreeBSD.org> <20220512201637.GR25951@gate.crashing.org> <56585bab-71b3-1713-d8ed-bed80cfe5ec4@linux.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xOYEwNaX6HX0mxCl" Content-Disposition: inline In-Reply-To: <56585bab-71b3-1713-d8ed-bed80cfe5ec4@linux.ibm.com> X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 May 2022 05:46:51 -0000 --xOYEwNaX6HX0mxCl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I'm abandoning this patch. It was fixed in FreeBSD instead to have feenable= except() in libm in https://cgit.freebsd.org/src/commit/?id=3D448c505c33cc3= 34193590f3844406d6a74f26e2a Thanks for your insight! On 22-05-13 10:59:59, Kewen.Lin wrote: > on 2022/5/13 04:16, Segher Boessenkool wrote: > > Hi Piotr, > >=20 > > On Tue, May 03, 2022 at 12:21:12PM +0200, pkubaj@FreeBSD.org wrote: > >> FreeBSD/powerpc* has feenableexcept() defined in fenv.h header. > >=20 > > Declared, not defined. These are required to be real functions (on all > > platforms that have these functions), not macros or inlines or whatever. > >=20 >=20 > Piotr's reply "FreeBSD doesn't have this function in libm, it's > implemented in /usr/include/fenv.h." from [1] made me feel like > it's a definition instead of declaration. So I thought the check > should use AC_LINK_IFELSE instead, since one fenv.h which doesn't > have the definition can still pass the proposed AC_COMPILE_IFELSE > check. >=20 > I just did a further search, the powerpc fenv.h [2] does include > the definition of feenableexcept. By comparison, the x86 fenv.h [3] > doesn't. But I'm not sure if it's the same as what Piotr's > environments have. Hope it's similar. :-) >=20 > [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-April/593193.html > [2] https://github.com/freebsd/freebsd-src/blob/main/lib/msun/powerpc/fen= v.h > [3] https://github.com/freebsd/freebsd-src/blob/main/lib/msun/x86/fenv.h >=20 > BR, > Kewen >=20 --xOYEwNaX6HX0mxCl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmJ/QkEACgkQelmbhSCD nJ0doBAAmyOl5uLPNga7wE62M5Ky8hPinXTtcIBAmTXwFRyyt6Td+spjCNLdAjwf fF5SusFk8SuERL4DYJl7rjktVQdegekQ8cYsigeaOPMDiqe7L8FPdhwbUwZX59FD pMV7DcxGQENAgU+71G+/v2zjuyQkBbGbaP01Zga02ZP7Rn0mlr7a7MpyZ6r0oasx nPCEQYBjMlYLK+zeqwmFuf0kaRD+V0rbhgnO9IMmrqpgVCMgKG5Bf3UXZ+FTeSG5 6ur/yiHa0GmsyoRelp6+pkO6sfiA6R3Xfrr5yoUcjLElxPDYcM94Xc3xZ8BqOmXb O5u3KPMGH/88qnngyf02bKAUILltUB8E4SwqqDUoQo0X2V9SV84aB+RaqM9C3rX4 b99j8nfvp3UEVZUEU3hHYTJ1ycaxid8YTi9DFTDHBn98MOA2aTP5l1F2R5nqlz4E BoLLfW8iEXGXicFoyqwgNlcInvz2JLNrVgSOXg8Y0jZ79o6IuS1txBzUEhEudIns erRYmCjm6kS/Ik73pdmO2MHQmAlYryGaPP8KNwbGqrn23O2b1o5sb40gDwulavz7 gpdp1q6F5OTDDVG+vC7wrv+1wehwlP/VrlrJRT6kR7serkAOr8JvEEd5Yu3521Mr HllT9jx6DMnBGkouCuZ6bQNS4ArVlXwbRCWFXVprtePn6E86qDw= =AHRt -----END PGP SIGNATURE----- --xOYEwNaX6HX0mxCl--