From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D26B53858025 for ; Wed, 4 May 2022 16:53:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D26B53858025 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-542-wdpjnJtjPXieCO_wPJKplA-1; Wed, 04 May 2022 12:53:35 -0400 X-MC-Unique: wdpjnJtjPXieCO_wPJKplA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 896F0384F807; Wed, 4 May 2022 16:53:34 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 235752166B41; Wed, 4 May 2022 16:53:33 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 244GrVkj1697363 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 May 2022 18:53:31 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 244GrU0G1697362; Wed, 4 May 2022 18:53:30 +0200 Date: Wed, 4 May 2022 18:53:30 +0200 From: Jakub Jelinek To: Hafiz Abid Qadeer Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PATCH] Add a restriction on allocate clause (OpenMP 5.0) Message-ID: Reply-To: Jakub Jelinek References: <20220218231316.3186096-1-abidh@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <20220218231316.3186096-1-abidh@codesourcery.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 16:53:38 -0000 On Fri, Feb 18, 2022 at 11:13:16PM +0000, Hafiz Abid Qadeer wrote: > An allocate clause in target region must specify an allocator > unless the compilation unit has requires construct with > dynamic_allocators clause. Current implementation of the allocate > clause did not check for this restriction. This patch fills that > gap. > > gcc/ChangeLog: > > * omp-low.cc (omp_maybe_offloaded_ctx): New prototype. > (scan_sharing_clauses): Check a restriction on allocate clause. > > gcc/testsuite/ChangeLog: > > * c-c++-common/gomp/allocate-2.c: Add tests. > * c-c++-common/gomp/allocate-8.c: New test. > * gfortran.dg/gomp/allocate-3.f90: Add tests. > * gcc.dg/gomp/pr104517.c: Update. I think it has even stronger requirement, that the allocator is present and is present in uses_allocators clause. But we don't parse uses_allocators, so this is a good step forward. Ok. Jakub