Re: [PATCH] OpenMP, libgomp: Add new runtime routines omp_target_memcpy_async and omp_target_memcpy_rect_async

[Jakub Jelinek <jakub@redhat.com>]

On Thu, May 19, 2022 at 10:39:05AM +0200, Marcel Vollweiler wrote:
> > add here
> >    else
> >      {
> >        depend[0] = 0;
> > ...
> >      }
> 
> Added the "depend" definition to the "if" branch (instead the "else" branch).

Thanks for correcting my thinko.

> gcc/ChangeLog:
> 
> 	* omp-low.cc (omp_runtime_api_call): Added target_memcpy_async and
> 	target_memcpy_rect_async to omp_runtime_apis array.
> 
> libgomp/ChangeLog:
> 
> 	* libgomp.map: Added omp_target_memcpy_async and
> 	omp_target_memcpy_rect_async.
> 	* libgomp.texi: Both functions are now supported.
> 	* omp.h.in: Added omp_target_memcpy_async and
> 	omp_target_memcpy_rect_async.
> 	* omp_lib.f90.in: Added interfaces for both new functions.
> 	* omp_lib.h.in: Likewise.
> 	* target.c (ialias_redirect): Added for GOMP_task.
> 	(omp_target_memcpy): Restructured into check and copy part.
> 	(omp_target_memcpy_check): New helper function for omp_target_memcpy and
> 	omp_target_memcpy_async that checks requirements.
> 	(omp_target_memcpy_copy): New helper function for omp_target_memcpy and
> 	omp_target_memcpy_async that performs the memcpy.
> 	(omp_target_memcpy_async_helper): New helper function that is used in
> 	omp_target_memcpy_async for the asynchronous task.
> 	(omp_target_memcpy_async): Added.
> 	(omp_target_memcpy_rect): Restructured into check and copy part.
> 	(omp_target_memcpy_rect_check): New helper function for
> 	omp_target_memcpy_rect and omp_target_memcpy_rect_async that checks
> 	requirements.
> 	(omp_target_memcpy_rect_copy): New helper function for
> 	omp_target_memcpy_rect and omp_target_memcpy_rect_async that performs
> 	the memcpy.
> 	(omp_target_memcpy_rect_async_helper): New helper function that is used
> 	in omp_target_memcpy_rect_async for the asynchronous task.
> 	(omp_target_memcpy_rect_async): Added.
> 	* task.c (ialias): Added for GOMP_task.
> 	* testsuite/libgomp.c-c++-common/target-memcpy-async-1.c: New test.
> 	* testsuite/libgomp.c-c++-common/target-memcpy-async-2.c: New test.
> 	* testsuite/libgomp.c-c++-common/target-memcpy-rect-async-1.c: New test.
> 	* testsuite/libgomp.c-c++-common/target-memcpy-rect-async-2.c: New test.
> 	* testsuite/libgomp.fortran/target-memcpy-async-1.f90: New test.
> 	* testsuite/libgomp.fortran/target-memcpy-async-2.f90: New test.
> 	* testsuite/libgomp.fortran/target-memcpy-rect-async-1.f90: New test.
> 	* testsuite/libgomp.fortran/target-memcpy-rect-async-2.f90: New test.

Ok, thanks.

	Jakub