From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8016C3842AE3 for ; Thu, 30 Jun 2022 12:51:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8016C3842AE3 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-609-U2Ccxe3RO7-Ouk-IoNqA3A-1; Thu, 30 Jun 2022 08:51:43 -0400 X-MC-Unique: U2Ccxe3RO7-Ouk-IoNqA3A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8FDD0811E80; Thu, 30 Jun 2022 12:51:42 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B32E4050C4B; Thu, 30 Jun 2022 12:51:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 25UCpdgx4007317 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 30 Jun 2022 14:51:40 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 25UCpc604007316; Thu, 30 Jun 2022 14:51:38 +0200 Date: Thu, 30 Jun 2022 14:51:38 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] Fortran: Cleanup OpenMP match{o,s,do,ds} macros Message-ID: Reply-To: Jakub Jelinek References: <783d48b1-3939-19c6-78ce-dc0e0cc59231@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <783d48b1-3939-19c6-78ce-dc0e0cc59231@codesourcery.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 12:51:47 -0000 On Thu, Jun 30, 2022 at 02:30:24PM +0200, Tobias Burnus wrote: > OK for mainline - or should I put that patch into the bin? Not sure, the other match* macros also aren't wrappers around another macro and with the internal macro it means we'll need to parse more many times (even when we then fold the conditions quite early). > +/* Like match, but with some special handling: > + - dosimd - if false, don't do anything if not -fopenmp, > + otherwise do match_word_omp_simd matching > + - if dospec_only: if spec_only, goto do_spec_only after matching. > + > + If the directive matched but the clauses failed, do not start > + matching the next directive in the same switch statement. */ > + > +#define match_internal(match_simd, match_spec_only, keyword, subr, st) \ It at least should be matcho_internal or have the OpenMP stuff in the name somehow, because it is quite OpenMP specific and isn't used by match or matcha etc. > +/* Like match. Does simd matching; sets flag simd_matched if keyword matched. */ Twice missing 2 spaces after . Jakub