From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0BD4038312A3 for ; Tue, 28 Jun 2022 10:57:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0BD4038312A3 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-478-awS73jqvM0Cfonkso-xfYA-1; Tue, 28 Jun 2022 06:57:17 -0400 X-MC-Unique: awS73jqvM0Cfonkso-xfYA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58213101A589; Tue, 28 Jun 2022 10:57:17 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1E6C415F5E; Tue, 28 Jun 2022 10:57:16 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 25SAvDgU3973320 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 28 Jun 2022 12:57:14 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 25SAvBB43973319; Tue, 28 Jun 2022 12:57:11 +0200 Date: Tue, 28 Jun 2022 12:57:11 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: Mikael Morin , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org, Harald Anlauf , "Joseph S. Myers" Subject: Re: [PATCH] fortran, libgfortran, v3: Avoid using libquadmath for glibc 2.26+ Message-ID: Reply-To: Jakub Jelinek References: <70657edb-4055-e183-7e09-5e1321beb7f5@orange.fr> <38312dfa-76c6-ee85-9f6a-80c6e2f7bcdb@orange.fr> <01d38605-13f7-d785-a461-1c6826550b4e@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <01d38605-13f7-d785-a461-1c6826550b4e@codesourcery.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 10:57:22 -0000 On Tue, Jun 28, 2022 at 10:35:03AM +0200, Tobias Burnus wrote: > On 27.06.22 15:30, Jakub Jelinek via Gcc-patches wrote: > > > Ok, here is an updated patch that uses _Float128/_Complex _Float128 for all > > of GFC_REAL_{16,17}_IS_FLOAT128, but still uses q/Q suffixes on literal > > constants etc. when using libquadmath and f128/F128 otherwise. > > This patch also includes the incremental powerpc64le fixes. > > > > Ok if it passes testing? > > LGTM – I am not completely happy of having a TARGET_GLIBC_M{AJ,IN}OR check > in the FE I've used it because it is already (though my fault too) used for the powerpc64le stuff in the FE too. The alternative would be grepping of target glibc headers in gcc/configure.ac, because I think we can't during gcc configure time preprocess the target glibc header (at least not reliably) because at that point we just have host compiler which might be a different architecture. So, we could e.g. grep for grep '^[[:blank:]]*#[[:blank:]]*define[[:blank:]]*__HAVE_FLOAT128[[:blank:]]*1' $target_header_dir/bits/floatn.h or so. Currently all arches that do have the IEC 60559 _Float128 *f128 APIs in glibc were added in glibc 2.26, if some extra are added later or some other libraries add those, we can always improve the checks. Jakub