From: Jakub Jelinek <jakub@redhat.com>
To: Iain Sandoe <idsandoe@googlemail.com>
Cc: Mikael Morin <morin-mikael@orange.fr>,
GCC Patches <gcc-patches@gcc.gnu.org>,
GCC Fortran <fortran@gcc.gnu.org>
Subject: Re: [PATCH] fortran, v2: Add -static-libquadmath support [PR46539]
Date: Thu, 18 Aug 2022 12:41:35 +0200 [thread overview]
Message-ID: <Yv4XX0oEZU6elu+9@tucnak> (raw)
In-Reply-To: <55BAB9E6-B67B-4686-BAFD-AB06C0740990@googlemail.com>
On Thu, Aug 18, 2022 at 11:35:06AM +0100, Iain Sandoe wrote:
> > --- gcc/fortran/options.cc.jj 2022-01-18 11:58:59.568982256 +0100
> > +++ gcc/fortran/options.cc 2022-08-16 14:56:22.807525218 +0200
> > @@ -692,6 +692,13 @@ gfc_handle_option (size_t scode, const c
> > #endif
> > break;
> >
> > + case OPT_static_libquadmath:
> > +#ifndef HAVE_LD_STATIC_DYNAMIC
> > + gfc_fatal_error ("%<-static-libquadmath%> is not supported in this "
> > + "configuration");
> > +#endif
>
> I think that this will disable the option on Darwin (where the linker does not
> support Bstatic/dynamic) - the point of the specs outfile substitution is to work
> for such platforms. So long as the option is not stripped out by the driver, the
> specs substitution should work (there is a bug in the g++ driver where this is
> not happening properly for -static-libstdc++ - but the gdc driver has it right).
It does the same thing as OPT_static_libgfortran and that option
presumably isn't disabled on Darwin.
My guess is that this is just dead code and could be removed for both
options, I think gfc_handle_option is only in f951 program, and the
-static-lib* options are driver only, not passed to the compiler.
Note, for other options like -static-libstdc++, we also don't reject them
if HAVE_LD_STATIC_DYNAMIC isn't defined.
Jakub
prev parent reply other threads:[~2022-08-18 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 14:31 [PATCH] fortran: " Jakub Jelinek
2022-08-17 7:19 ` Jakub Jelinek
2022-08-17 7:55 ` Tobias Burnus
2022-08-17 8:28 ` Mikael Morin
2022-08-17 11:05 ` [PATCH] fortran, v2: " Jakub Jelinek
2022-08-18 10:35 ` Iain Sandoe
2022-08-18 10:41 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv4XX0oEZU6elu+9@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=idsandoe@googlemail.com \
--cc=morin-mikael@orange.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).