From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] OpenMP: Document ompx warnings + add Fortran omx warning [PR106670]
Date: Thu, 8 Sep 2022 17:47:25 +0200 [thread overview]
Message-ID: <YxoOjd4MSVTUKSMk@tucnak> (raw)
In-Reply-To: <ffd89508-87fb-8586-cbda-e045cd10e5a0@codesourcery.com>
On Mon, Aug 29, 2022 at 11:24:52AM +0200, Tobias Burnus wrote:
> PR fortran/106670
>
> gcc/fortran/ChangeLog:
>
> * scanner.cc (skip_fixed_omp_sentinel): Add -Wsurprising warning
> for 'omx' sentinels with -fopenmp.
> * invoke.texi (-Wsurprising): Document additional warning case.
>
> libgomp/ChangeLog:
>
> * libgomp.texi (OpenMP 5.2): Add comment to ompx/omx entry.
>
> gcc/testsuite/ChangeLog:
>
> * c-c++-common/gomp/ompx-1.c: New test.
> * c-c++-common/gomp/ompx-2.c: New test.
> * g++.dg/gomp/ompx-attrs-1.C: New test.
> * gfortran.dg/gomp/ompx-1.f90: New test.
> * gfortran.dg/gomp/omx-1.f: New test.
> * gfortran.dg/gomp/omx-2.f: New test.
> --- a/libgomp/libgomp.texi
> +++ b/libgomp/libgomp.texi
> @@ -359,7 +359,13 @@ to address of matching mapped list item per 5.1, Sect. 2.21.7.2 @tab N @tab
> @item @code{omp_in_explicit_task} routine and @emph{implicit-task-var} ICV
> @tab N @tab
> @item @code{omp}/@code{ompx}/@code{omx} sentinels and @code{omp_}/@code{ompx_}
> - namespaces @tab N/A @tab
> + namespaces @tab N/A
> + @tab warning for @code{omp/ompx} sentinels@footnote{@code{omp/ompx}
> + sentinels as C/C++ pragma and C++ attributes are warned for with
> + @code{-Wunknown-pragmas} (implied by @code{-Wall}) and @code{-Wattributes}
> + (by default), respectively; for Fortran free-source code, the there is a
s/by default/enabled by default/
s/the there/there/
> + warning by default and for fixed-source code with @code{-Wsurprising}
s/by default/enabled by default/
> + (enabled by @code{-Wall})}
> @item Clauses on @code{end} directive can be on directive @tab N @tab
> @item Deprecation of no-argument @code{destroy} clause on @code{depobj}
> @tab N @tab
Otherwise LGTM.
Jakub
prev parent reply other threads:[~2022-09-08 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 9:24 Tobias Burnus
2022-08-29 9:24 ` Tobias Burnus
2022-09-08 15:47 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxoOjd4MSVTUKSMk@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).