From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 92EE43858C74 for ; Thu, 8 Sep 2022 15:47:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 92EE43858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662652053; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=TDTQHcn6mV6wcRtKTKqZ3Z/YX0N6q3HrD58kMtBPU+E=; b=J5nf6zNCXq1jlXUiXvlysWCYF3guDmnR2IeWz20lenjW+xd02G6dfDC0s9scWMwCVAR+eN M1FQNl3aM8BWdT+ogcMnQyYvr2NEcDZD9sbYatslFEYqHfYXyE5RuhHbXBEDX2wSGNn4HC 9vaZgMnu0JWvogzEf925/BH2rHdsS8E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-x8umn8RMNeqeU7d-iOnovg-1; Thu, 08 Sep 2022 11:47:29 -0400 X-MC-Unique: x8umn8RMNeqeU7d-iOnovg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8B3F785A58A; Thu, 8 Sep 2022 15:47:29 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47E4C1415102; Thu, 8 Sep 2022 15:47:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 288FlQlr1563810 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 8 Sep 2022 17:47:26 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 288FlP4b1563809; Thu, 8 Sep 2022 17:47:25 +0200 Date: Thu, 8 Sep 2022 17:47:25 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] OpenMP: Document ompx warnings + add Fortran omx warning [PR106670] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 29, 2022 at 11:24:52AM +0200, Tobias Burnus wrote: > PR fortran/106670 > > gcc/fortran/ChangeLog: > > * scanner.cc (skip_fixed_omp_sentinel): Add -Wsurprising warning > for 'omx' sentinels with -fopenmp. > * invoke.texi (-Wsurprising): Document additional warning case. > > libgomp/ChangeLog: > > * libgomp.texi (OpenMP 5.2): Add comment to ompx/omx entry. > > gcc/testsuite/ChangeLog: > > * c-c++-common/gomp/ompx-1.c: New test. > * c-c++-common/gomp/ompx-2.c: New test. > * g++.dg/gomp/ompx-attrs-1.C: New test. > * gfortran.dg/gomp/ompx-1.f90: New test. > * gfortran.dg/gomp/omx-1.f: New test. > * gfortran.dg/gomp/omx-2.f: New test. > --- a/libgomp/libgomp.texi > +++ b/libgomp/libgomp.texi > @@ -359,7 +359,13 @@ to address of matching mapped list item per 5.1, Sect. 2.21.7.2 @tab N @tab > @item @code{omp_in_explicit_task} routine and @emph{implicit-task-var} ICV > @tab N @tab > @item @code{omp}/@code{ompx}/@code{omx} sentinels and @code{omp_}/@code{ompx_} > - namespaces @tab N/A @tab > + namespaces @tab N/A > + @tab warning for @code{omp/ompx} sentinels@footnote{@code{omp/ompx} > + sentinels as C/C++ pragma and C++ attributes are warned for with > + @code{-Wunknown-pragmas} (implied by @code{-Wall}) and @code{-Wattributes} > + (by default), respectively; for Fortran free-source code, the there is a s/by default/enabled by default/ s/the there/there/ > + warning by default and for fixed-source code with @code{-Wsurprising} s/by default/enabled by default/ > + (enabled by @code{-Wall})} > @item Clauses on @code{end} directive can be on directive @tab N @tab > @item Deprecation of no-argument @code{destroy} clause on @code{depobj} > @tab N @tab Otherwise LGTM. Jakub