From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 78F973858D37 for ; Wed, 14 Sep 2022 10:35:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 78F973858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663151704; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=0nxvnZXFNIEs4EhZMGT3v44jhSZHmMckOQlnTovqqeA=; b=V80ppMR/MgJVD4o2DdKp+nYHv5WEOgd5B+XpDb74QBZx1QYRKHCS/rFVj7wOcHEB8la73c MflwmRPPgGAP5Lz3BzNBitw5W7lFkLBHS0jwx1I+QfwtWkP6CmkmJFpQrTiLnFw97Twk/g VgEoRLRR8Mk/J8Wnpf35lJKZiW4mOmg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-651-NSLRyndMPHOYJuhmXymuNw-1; Wed, 14 Sep 2022 06:35:00 -0400 X-MC-Unique: NSLRyndMPHOYJuhmXymuNw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F94D185A78B; Wed, 14 Sep 2022 10:35:00 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CE1B492CA2; Wed, 14 Sep 2022 10:34:59 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 28EAYvFT1975468 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 14 Sep 2022 12:34:57 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 28EAYuIm1975467; Wed, 14 Sep 2022 12:34:56 +0200 Date: Wed, 14 Sep 2022 12:34:55 +0200 From: Jakub Jelinek To: Julian Brown Cc: gcc-patches@gcc.gnu.org, tobias@codesourcery.com, fortran@gcc.gnu.org Subject: Re: [PATCH v3 01/11] OpenMP 5.0: Clause ordering for OpenMP 5.0 (topological sorting by base pointer) Message-ID: Reply-To: Jakub Jelinek References: <839df7d51e5bf6f29054e83b3c017f57df5c1149.1663101299.git.julian@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <839df7d51e5bf6f29054e83b3c017f57df5c1149.1663101299.git.julian@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 13, 2022 at 02:01:42PM -0700, Julian Brown wrote: > --- a/gcc/omp-low.cc > +++ b/gcc/omp-low.cc > @@ -1599,8 +1599,11 @@ scan_sharing_clauses (tree clauses, omp_context *ctx) > { > /* If this is an offloaded region, an attach operation should > only exist when the pointer variable is mapped in a prior > - clause. */ > - if (is_gimple_omp_offloaded (ctx->stmt)) > + clause. > + If we had an error, we may not have attempted to sort clauses > + properly, so avoid the test. */ > + if (is_gimple_omp_offloaded (ctx->stmt) > + && !seen_error ()) I'll repeat that it would be better if we just leave out the whole GOMP_TARGET if there were errors regarding it and the clauses aren't sorted properly. But I'm ok if it is handled incrementally and this spot reverted. Otherwise LGTM. Jakub