From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Harald Anlauf via Fortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, tobias@codesourcery.com
Subject: Re: [PATCH] Fortran: fix CLASS attribute handling [PR106856]
Date: Fri, 3 Mar 2023 11:57:44 -0800 [thread overview]
Message-ID: <ZAJROLZ2n2gnvin3@troutmask.apl.washington.edu> (raw)
In-Reply-To: <trinity-b92172eb-3e6e-401c-82e2-f5e1b3cee6b2-1677794628453@3c-app-gmx-bs40>
On Thu, Mar 02, 2023 at 11:03:48PM +0100, Harald Anlauf via Fortran wrote:
> - if (attr->class_ok)
> - /* Class container has already been built. */
> + /* Class container has already been built with same name. */
> + if (attr->class_ok
> + && ts->u.derived->components->attr.dimension >= attr->dimension
> + && ts->u.derived->components->attr.codimension >= attr->codimension
> + && ts->u.derived->components->attr.class_pointer >= attr->pointer
> + && ts->u.derived->components->attr.allocatable >= attr->allocatable)
I suppose I'm a bit confused here. dimension, codimension,
pointer and allocatable are 1-bit bitfields in the attr
struct. These can have the values 0 and 1, so the above
conditionals are always true.
The rest of the patch looks reasonable. If Tobias has no
objections or comments, it's ok to commit once the above
is explained.
--
Steve
next prev parent reply other threads:[~2023-03-03 19:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 22:03 Harald Anlauf
2023-03-03 19:57 ` Steve Kargl [this message]
2023-03-03 21:17 ` Harald Anlauf
2023-03-03 21:24 ` Mikael Morin
2023-03-03 22:18 ` Steve Kargl
2023-03-04 13:56 ` Mikael Morin
2023-03-04 16:02 ` [PATCH, v2] " Harald Anlauf
2023-03-04 16:02 ` Harald Anlauf
2023-03-04 16:06 ` Harald Anlauf
2023-03-04 16:06 ` Harald Anlauf
2023-03-04 17:09 ` Mikael Morin
2023-03-04 21:20 ` Harald Anlauf
2023-03-04 22:29 ` Mikael Morin
2023-03-05 20:21 ` [PATCH, v3] " Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAJROLZ2n2gnvin3@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).