From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by sourceware.org (Postfix) with ESMTPS id 2E39D385840F for ; Fri, 12 May 2023 14:24:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E39D385840F Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=kitware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kitware.com Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-61a4e03ccbcso90840056d6.2 for ; Fri, 12 May 2023 07:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; t=1683901498; x=1686493498; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=k2csmahbtzbmYrIp5dBJ19ydlne/Llk6N/BWRqVcTGg=; b=iLV4yKr+nVNW79AJWMweWnep6LfJsvudPCmHCzP/t5RBAW7eq/Bj8ZcY4Wk12KMpce te00RlNzegYrvjUTdsT3qSBhMpGTUgT2+eF0GdPp6Bql5jW40IWvrI8huCckK8UhcOeG LhyKTt5h2Ldiz183THuxB6H1qEd3llVN386xA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683901498; x=1686493498; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2csmahbtzbmYrIp5dBJ19ydlne/Llk6N/BWRqVcTGg=; b=NYqTFsgZ0gdIcwy3HY8doBq5Hzc8rsey3Y4r6WBEUaqWx1TWkEPsM6PyeWyCoGGMh5 TT5nSccGCTESLLIrKa5c4vVV6G6eTXoYVa4TQmK8vXPoTmJ5evvXU2h11DU1ngXL2nlN ZStNj04+0+8I/k5fjpqw0kEUe/Po7huRA+aBbuIOW1A9QrkGdhzjJ5LiSp5zXAxeX5ls cOTugoNKMdP34pyv3neXKv/Jf2nI508brEdGgkJbO3FuIPPF3dguqRE47Ns4IgyhzfJg qcacitEwfs8FKr7IzlqDwpSH4pf8NoXdU6yiNZwGPi1yI/A5gF5m1UAz+VRn6dMmbJuY a7WA== X-Gm-Message-State: AC+VfDyrmHir1QYpC8xhBnFY05J7Y6HtqcFUClFJXOGpg+ijaVON2xUL g32G/TQ0tbWWLskkdcaZ/0vuVg== X-Google-Smtp-Source: ACHHUZ63TiTBh29tr1KkL9VuK4t01Nq90L+6YNgjbacaJZ2393/rjyuqFM1kNcK6VhBtXd+k85xVqw== X-Received: by 2002:a05:6214:dab:b0:5a9:1bd5:375e with SMTP id h11-20020a0562140dab00b005a91bd5375emr41883891qvh.21.1683901497857; Fri, 12 May 2023 07:24:57 -0700 (PDT) Received: from localhost (cpe-142-105-146-128.nycap.res.rr.com. [142.105.146.128]) by smtp.gmail.com with ESMTPSA id j12-20020ac8404c000000b003eeff94e2f8sm3140721qtl.0.2023.05.12.07.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 07:24:57 -0700 (PDT) Date: Fri, 12 May 2023 10:24:56 -0400 From: Ben Boeckel To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com Subject: Re: [PATCH v5 3/5] p1689r5: initial support Message-ID: References: <20230125210636.2960049-1-ben.boeckel@kitware.com> <20230125210636.2960049-4-ben.boeckel@kitware.com> <77ee5db6-e45e-5178-4807-5b2fef29e8c7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <77ee5db6-e45e-5178-4807-5b2fef29e8c7@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 14, 2023 at 16:50:27 -0500, Jason Merrill wrote: > I notice that the actual flags are all -fdep-*, though some of them are > -fdeps-* here, and the internal variables all seem to be fdeps_*. I > lean toward harmonizing on "deps", I think. Done. > I don't love the three separate options, but I suppose it's fine. I'd > prefer "target" instead of "output". Done. > It should be possible to omit both -file and -target and get reasonable > defaults, like the ones for -MD/-MQ in gcc.cc:cpp_unique_options. `file` can be omitted (the `output_stream` will be used then). I *think* I see that adding: %{fdeps_file:-fdeps-file=%{!o:%b.ddi}%{o*:%.ddi%*}} would at least do for `-fdeps-file` defaults? I don't know if there's a reasonable default for `-fdeps-target=` though given that this command line has no information about the object file that will be used (`-o` is used for preprocessor output since we're leaning on `-E` here). --Ben