From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by sourceware.org (Postfix) with ESMTPS id 4F126385381D for ; Fri, 12 May 2023 14:26:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F126385381D Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=kitware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kitware.com Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-4301281573aso3144301137.3 for ; Fri, 12 May 2023 07:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; t=1683901613; x=1686493613; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=csfGOaXpjbyi+KJRrM8u9+hYuJ3ledBBmGFEsLeIPIA=; b=LvIQLK98+k6NuE427PnCEcIQCRoiGBiky/LlQOCB0OKKedl2i6NR56nT0lNhB2t2Sk XWYBWXeOHJNMhUmr+qJRb8L3z9zUMP8L6l1vCJ9qP2o7j7vzU+pjRjkOuuzmRHVk4GyI WhpXFtADuMjB0CRpeWmubaIN2HXsxMbBs5/84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683901613; x=1686493613; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=csfGOaXpjbyi+KJRrM8u9+hYuJ3ledBBmGFEsLeIPIA=; b=ASVY6C3KNWtvlwxDAysSlYVymKSMMguku53T6rHN64HTh8lNNOl4sRhL8YMXhsFfdI Z2GbiJWDi2V1ytbVh0e6QmmWj4tOzkcwY72bQpZ1c+PCaXJLzE7ccH+7oNupsmaApfL2 dWZoZc+Pihdf6on0Ntww8/BOoMFlCOy6DQBAssBkfBSmjTGpAs5Xdx75vZCHmFE5S9Ey ge/cO0diAdGyDZOx0+4/IEIBiIEZ2abvcOxqZOiAY4fdnb+opMFaJVxA6mNw1hZ+VHdR ucqij8cMiIrr+Ft0HqWqTccFJ3d6KxMva8n/qU0VayG6r/IAdKzkb4WXCt3kk14UVqma kwWw== X-Gm-Message-State: AC+VfDyHb12W6YpEwaMBYIhg9FLG1x81wo2jiMFd1nrqBPWbdnqsKXpb akR44mzoPkhyM+mOvw4AJNUT7A== X-Google-Smtp-Source: ACHHUZ5T/LBB0u8HoDYoUvreHctJAboYJiMcuTZy9QulMXvtTqhUb06Rdr48qYOmfePf0LjRfBrnAQ== X-Received: by 2002:a67:fe14:0:b0:436:eab:99f4 with SMTP id l20-20020a67fe14000000b004360eab99f4mr6375521vsr.29.1683901613466; Fri, 12 May 2023 07:26:53 -0700 (PDT) Received: from localhost (cpe-142-105-146-128.nycap.res.rr.com. [142.105.146.128]) by smtp.gmail.com with ESMTPSA id o11-20020ae9f50b000000b00759101c7e2esm1008653qkg.64.2023.05.12.07.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 07:26:53 -0700 (PDT) Date: Fri, 12 May 2023 10:26:52 -0400 From: Ben Boeckel To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com Subject: Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies Message-ID: References: <20230125210636.2960049-1-ben.boeckel@kitware.com> <20230125210636.2960049-5-ben.boeckel@kitware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Feb 13, 2023 at 13:33:50 -0500, Jason Merrill wrote: > Both this and the mapper dependency patch seem to cause most of the > modules testcases to crash; please remember to run the regression tests > (https://gcc.gnu.org/contribute.html#testing) Fixed for v6. `cpp_get_deps` can return `NULL` which `deps_add_dep` assumes to not be true; fixed by checking before calling. --Ben