public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Allin Cottrell via Fortran <fortran@gcc.gnu.org>
Subject: Re: Compile antiquated fortran?
Date: Thu, 27 Jul 2023 11:21:05 -0700	[thread overview]
Message-ID: <ZMK1kTmVjQ0JgonP@troutmask.apl.washington.edu> (raw)
In-Reply-To: <alpine.LFD.2.20.3.2307271328410.3084999@myrtle>

On Thu, Jul 27, 2023 at 01:36:46PM -0400, Allin Cottrell via Fortran wrote:
> I have old fortran source code (not my own work) for a specialized
> statistical program that I and others find quite useful.
> 
> A few years ago I was able to compile it on Linux using gfortran with
> std=legacy (and also cross-compile it for Windows an Mac). Now I'd like to
> rebuild it, but with recent gfortran (I've tried 12.2.1 on Fedora and 13.1.1
> on Arch) it's a no-go. I get lots of errors of the following sort:
> 
> ansub9.f:151:44:
> 
>   151 |    INTEGER ITYPE,INIT,LAM,IMEAN,IP,ID,Q,BP,BD,BQ,SQG,MQ,L,M,
>       |                                       1
> Error: Symbol ‘q’ at (1) already has basic type of REAL
> 
> I can understand this complaint. The code contains this sort of thing within
> a given subroutine:
> 
>        IMPLICIT  REAL*8 (A-H,O-Z)
> 
> then some lines later on:
> 
>        INTEGER ITYPE,INIT,LAM,IMEAN,P,D,Q,...
> 
> I guess the author was assuming that an explicit type-assignment just
> overrides an implicit one. Older gfortran apparently played along with that.
> 
> My question: Given that I'm already using -std=legacy, are there any other
> flags that I could add to get the code to compile?
> 
> (I know I could tackle this by renaming a bunch of variables, but in context
> that would be an extremely fiddly job.)
> 

I'm afraid we'll need to see some actual code.  The following compiles
without a problem.

       SUBROUTINE FOO(Q)
       IMPLICIT REAL*8 (A-H,O-Z)
       INTEGER Q
       Q = 1
       END

Hmmm, are DATA statements in the code?

       SUBROUTINE FOO
       IMPLICIT REAL*8 (A-H,O-Z)
       DATA Q/1/
       INTEGER Q
       Q = 1
       END

% gfortran12 -c -Wall a.f
a.f:4:16:

    4 |        INTEGER Q
      |                1
Error: Symbol 'q' at (1) already has basic type of REAL

gfortran is correct to complain here.  The DATA statement give
Q a REAL type due to the implicit statement.  Q can only appear
in a later declaration statement that re-affirms that type.

-- 
Steve

  reply	other threads:[~2023-07-27 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 17:36 Allin Cottrell
2023-07-27 18:21 ` Steve Kargl [this message]
2023-07-27 20:27 ` Jerry D
2023-07-27 23:09   ` Allin Cottrell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMK1kTmVjQ0JgonP@troutmask.apl.washington.edu \
    --to=sgk@troutmask.apl.washington.edu \
    --cc=fortran@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).