From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Harald Anlauf via Fortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: do not pass hidden character length for TYPE(*) dummy [PR110825]
Date: Fri, 28 Jul 2023 11:11:10 -0700 [thread overview]
Message-ID: <ZMQEvjxJpoeuCoZi@troutmask.apl.washington.edu> (raw)
In-Reply-To: <trinity-106acade-c06b-4bdf-8173-a189f07212dd-1690486793645@3c-app-gmx-bs10>
On Thu, Jul 27, 2023 at 09:39:53PM +0200, Harald Anlauf via Fortran wrote:
> Dear all,
>
> when passing a character actual argument to an assumed-type dummy
> (TYPE(*)), we should not pass the character length for that argument,
> as otherwise other hidden arguments that are passed as part of the
> gfortran ABI will not be interpreted correctly. This is in line
> with the current way the procedure decl is generated.
>
> The attached patch fixes the caller and clarifies the behavior
> in the documentation.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
OK. Patch looks small enough that if you are so inclined
to backport that's ok as well. Thanks for the quick response.
--
Steve
prev parent reply other threads:[~2023-07-28 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 19:39 Harald Anlauf
2023-07-28 18:11 ` Steve Kargl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMQEvjxJpoeuCoZi@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).