From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 625123858C5E for ; Wed, 18 Oct 2023 11:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 625123858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 625123858C5E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697626888; cv=none; b=I+CJe7b4uXpdihVRdNCcZ1hqpZ3+BxzNx7j8LhIqBQ5dq8EDsSBabxYSNXT6dpAA7XqNj1vr1e18750J0S2X8qtp9/T8wNf7shYUbWS+pGH0Fb3mAMCJ73Y2xO65c04WKi1+95ByvqykC5j+fI6dvBNoBdx891LMvRgdBisTs88= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697626888; c=relaxed/simple; bh=93Rq+Q0sOSoGDuJgSDcqC+Te74wpP8SIYkBs/z9W4xQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=nYIkqrSN6/JU9nWjxFC/Vy6MMg/SZaslw27cWHjDCSfM5QJp0ecN6tDSoBEdMIf6Czxsfsj6dDfddCCckyjxR77mG0xOPTgzP+7lW6bleoiEa7BdqbKGlFcsxQYBPEN+SgdJe4I6r8rMdrAwNCVldCQLv+42fNmPR29EBNY/0Qk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697626886; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fnyralRCPb8hCJOwzPPhi4FkqFZz0AzjFOrFOltmDXQ=; b=DR1ZFusaYFwxa5pG5hfI2deox0ybId7mE+/ChqIGmv8eT6j5w5hxtx0E7bleVaoIPomWSv 818+ZLs2wXNOYlYTkRQFBkGIT+UjaTA/AvuLYQGTF0gch2AgehGwM9jR0cMLmcDv7yapwz BnzQ5Mi3o+wKb3xU1LczQAHqweukyqw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-350-UzX1szMUNf-v4AoBUtIw2A-1; Wed, 18 Oct 2023 07:01:22 -0400 X-MC-Unique: UzX1szMUNf-v4AoBUtIw2A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67FFA86B8CA; Wed, 18 Oct 2023 11:01:22 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26AE0492BEF; Wed, 18 Oct 2023 11:01:21 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 39IB1J7F3463646 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 18 Oct 2023 13:01:19 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 39IB1InW3461744; Wed, 18 Oct 2023 13:01:18 +0200 Date: Wed, 18 Oct 2023 13:01:18 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, Thomas Schwinge Subject: Re: [Patch] OpenMP: Avoid ICE with LTO and 'omp allocate (was: [Patch] Fortran: Support OpenMP's 'allocate' directive for stack vars) Message-ID: Reply-To: Jakub Jelinek References: <457ea120-5cca-48e0-89d6-c3eab4234b61@codesourcery.com> <7f16971c-ff06-4e48-85e2-5b38828b7bc2@codesourcery.com> <87wmvkuwdv.fsf@euler.schwinge.homeip.net> <8d407d7b-c546-4454-92c1-707ef00f0ba0@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <8d407d7b-c546-4454-92c1-707ef00f0ba0@codesourcery.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 18, 2023 at 12:56:01PM +0200, Tobias Burnus wrote: > On 18.10.23 11:36, Jakub Jelinek wrote: > > On Wed, Oct 18, 2023 at 11:12:44AM +0200, Thomas Schwinge wrote: > > > +FAIL: gfortran.dg/gomp/allocate-13.f90 -O (internal compiler error: tree code 'statement_list' is not supported in LTO streams) > > Any references to GENERIC code in clauses etc. should have been gimplified > > or cleared during gimplification, we shouldn't support STATEMENT_LIST > > in LTO streaming. > > We only needed the statement list as aid during the gimplify.cc handling > of GOMP_alloc/GOMP_free for Fortran. How about just remove_attribute it > in that case? As discussed, as DECL_ATTRIBUTE gets added from the left > to the DECL_CHAIN, there shouldn't be a problem of introducing shared > trees; note that 'omp allocate' itself is added per DECL, i.e. it does > not introduce sharing itself, either. > > Tested with x86-64-gnu-linux. > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > OpenMP: Avoid ICE with LTO and 'omp allocate' > > gcc/ChangeLog: > > * gimplify.cc (gimplify_bind_expr): Remove "omp allocate" attribute > to avoid that auxillary statement list reaches to LTO. > > gcc/testsuite/ChangeLog: > > * gfortran.dg/gomp/allocate-13a.f90: New test. LGTM. Jakub