From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by sourceware.org (Postfix) with ESMTPS id A27323858418; Mon, 16 Oct 2023 18:37:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A27323858418 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=troutmask.apl.washington.edu Authentication-Results: sourceware.org; spf=none smtp.mailfrom=troutmask.apl.washington.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A27323858418 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=128.95.76.21 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697481473; cv=none; b=uYMf3hwEZOIYoVrXDWOL3p5HUdReT0mtMOuv658Z2NyBSnL4Ei8tgKm9HFIwkzVzx1LxFli+HC7OPJHiqfISOBoymINPAvoUXNWVuyi1s7eCDdsskGW6DgLUrSpE9zmcUdP2gvWspzf64f6V61FxoT/n9NAlqn/RzUVI+Az0JXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697481473; c=relaxed/simple; bh=Bl4RIJkLRMgMZimU0esgOBz4qIETKsniYO3AUgarDTc=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=t/cvSERCcCeW1qdoAce9Aml65jtpb1tgYEim3JacFcyyYbnUYM7332BoO+Zhn/VT895ZFDLKYAAM6DxVF1v3UsdOzvCpgdAkdIHw417P6jrn0JHomih4U27uWaoB1uAyQ6AASSbQr3PjKenJo7lxbk3vDT8ibhaOKiGvjCsI0sY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.17.1/8.17.1) with ESMTP id 39GIbfXx024585; Mon, 16 Oct 2023 11:37:41 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.17.1/8.17.1/Submit) id 39GIbf7x024584; Mon, 16 Oct 2023 11:37:41 -0700 (PDT) (envelope-from sgk) Date: Mon, 16 Oct 2023 11:37:41 -0700 From: Steve Kargl To: Harald Anlauf Cc: Tobias Burnus , gcc-patches , fortran Subject: Re: [patch] fortran/intrinsic.texi: Add 'passed by value' to signal handler Message-ID: Reply-To: sgk@troutmask.apl.washington.edu References: <3f2d2471-dd94-4eb1-86b2-ae7ed439028b@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f2d2471-dd94-4eb1-86b2-ae7ed439028b@gmx.de> X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 16, 2023 at 08:31:20PM +0200, Harald Anlauf wrote: > > Am 16.10.23 um 19:11 schrieb Tobias Burnus: > > Yesterday, someone was confused because the signal handler did not work. > > > > It turned out that the created Fortran procedure used as handler used > > pass by reference - and 'signal' passed the it by value. > > > > This patch adds the 'passed by value' to the wording: > > > > "@var{HANDLER} to be executed with a single integer argument passed by > > value" > > > > OK for mainline? > > I think the patch qualifies as obvious. > > While at it, you might consider removing the comment a few lines below > the place you are changing, > > @c TODO: What should the interface of the handler be? Does it take > arguments? > > and enhance the given example by e.g.: > > subroutine handler_print (signal_number) > integer, value :: signal_number > print *, "In handler_print: received signal number", signal_number > end subroutine handler_print > Good suggestion, Harald. I was composing a similar email when I saw yours pop into by inbox. -- Steve