From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B0BCF3858C50 for ; Mon, 11 Mar 2024 10:22:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0BCF3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B0BCF3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152533; cv=none; b=u/WXzzMSq4cXYRCmujIQuNYjX6K0R827ab0NjM/09069oJPWQ5J+YGpSy0Xs+2+X7owY9/HgnH5zrY3726lI77bnpAuU2/eUYj3KKxnjVQoVZLjL1QGvJ0YxKsZhLwUsFl+KgNz5UPE7Me2m8mFTJleyBa7wBVtlByMuF9WowCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152533; c=relaxed/simple; bh=UzoeYcHXYgSQi6r5kUj3l12WV/yzuVb/GSBdyvzdz10=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=XZ1KrUA/SXuKKowd8bd1s+HP928mETm8lXqBVWLz9oD9QFEWzTOiCEKMcsFcQ5ZcivjDIe6X/LgCrvhiKse4s9C8C/FqR/rY8fPb1ejA3lTBiU0pqJRE74omzVrkj6PnET0nCybd2uYUjJzvRQOg/a0KuvcZa3sc/iiNLkAwWZQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710152532; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=0u67CSGnG2EQAgxBkeV05k7CnzvHLYg3CIocZLoeP+w=; b=H25jyZ7pCLW7YLYwdvuZnSUODBqrMx1SvZrqstS9MnJnTZkJ+PFTTWr2OW6qMe+S6E8GJ0 hEtpxO1sy9BPCHmBxCv73oi/FBA7hP/yK99B+B4p4yWtcXwsX167D796Zr+QcBSOaUsFS9 tF4rWuXj8ShUOqBWECbhzPhX8Z7yumU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-n9C35b_gM2iy9ipgYqldBQ-1; Mon, 11 Mar 2024 06:22:10 -0400 X-MC-Unique: n9C35b_gM2iy9ipgYqldBQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B1338007A7; Mon, 11 Mar 2024 10:22:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.225.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 403B140C6CB7; Mon, 11 Mar 2024 10:22:10 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 42BAM884227656 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 11:22:08 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 42BAM8Io227655; Mon, 11 Mar 2024 11:22:08 +0100 Date: Mon, 11 Mar 2024 11:22:08 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , "fortran@gcc.gnu.org" Subject: Re: [Patch] OpenMP/Fortran: Fix defaultmap(none) issue with dummy procedures [PR114283] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Mar 11, 2024 at 11:07:46AM +0100, Tobias Burnus wrote: > Using dummy procedures in a target region with 'defaultmap(none)' leads to: > > Error: 'g' not specified in enclosing 'target' > > and this cannot be fixed by using 'firstprivate' as non-pointer dummy routines > are rejected as "Error: Object 'g' is not a variable". > > Fixed by doing the same for mapping as for data sharing: using predetermined > firstprivate. > > BTW: Only since GCC 14, 'declare target indirect' makes it possible to > simply use dummy procedures and procedures pointers in a target region. So firstprivate clause handling remaps them then if declare target indirect is used? If so, the patch looks reasonable to me. Jakub