From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by sourceware.org (Postfix) with ESMTPS id 922463858C98; Wed, 27 Mar 2024 16:43:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 922463858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=troutmask.apl.washington.edu Authentication-Results: sourceware.org; spf=none smtp.mailfrom=troutmask.apl.washington.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 922463858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=128.95.76.21 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711557818; cv=none; b=l9wlBnxIliaHwWo9iCapYRsJgf6gZcP5ReXnKVQFuAz2vdWHcu5YsFTt10naz8QSeYbcFOyO4ta4k8ZX53WvVFXk1H+FchmBoTw5vzw41t4nO8CmONABVoSiMcQ4DFIIhRjNjIekmFiL/pYH6CF4doHsnm6mr9/endN9Np6wwFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711557818; c=relaxed/simple; bh=fpkXlQczW56/MZQi8nddxKnSjOF52o5tzcSL24Dqj9s=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=cuohIRiAJSt4rvU6N/sX0z3QwwjyB2sLF4sDZVm2uelRsHN4iTrW+dHu5G34c444wfW6VQTdCw4I1yLd23ybRplDiPoo97hIWEPFeRejWO0ZcIpuQW15idc0Vj92I/1M2zgDmTiktcaVKlldLVKhdhMNwTN80vsxUJ9rPuik15Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.17.1/8.17.1) with ESMTP id 42RGhZOP079993; Wed, 27 Mar 2024 09:43:35 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) DKIM-Filter: OpenDKIM Filter v2.10.3 troutmask.apl.washington.edu 42RGhZOP079993 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=troutmask.apl.washington.edu; s=troutmask; t=1711557815; bh=fpkXlQczW56/MZQi8nddxKnSjOF52o5tzcSL24Dqj9s=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=hRrPBJ5ylvtWR1LSE8jcFp2fVKzSqcZkV5E6WK4BLoM/p9oisFkGwYuGgiO3O1Cdo tdhopiZ0tFejXRzCaNMPOmmMXIw2VhHpX1c9oik20/Kb6xsssILlA+zD0DHDtJWKLt uD40PKkmC8aiOvvwxk/BdGCZLkcbP7/mkOwehW1Zi5+KeK26GI9KC/ba4a/nRBg2Nu NarfcouPptf6OA/j+5rpFHt6EB887oJM0jO1BHWhzVLACnYs/idpMFxCjb3JgEhw6G 7n56ilzYVofz8qnQyM3jfVZSeSw26YLEXbuWq9vDXATJcJWkdlq4mDRK6uG5wtHOl8 TGSFfLDcVdvtw== Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.17.1/8.17.1/Submit) id 42RGhZtT079992; Wed, 27 Mar 2024 09:43:35 -0700 (PDT) (envelope-from sgk) Date: Wed, 27 Mar 2024 09:43:35 -0700 From: Steve Kargl To: Mikael Morin Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fortran: Fix specification expression check in submodules [PR114475] Message-ID: Reply-To: sgk@troutmask.apl.washington.edu References: <20240327153043.527359-1-mikael@gcc.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327153043.527359-1-mikael@gcc.gnu.org> X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_INVALID,DKIM_SIGNED,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 27, 2024 at 04:30:42PM +0100, Mikael Morin wrote: > Hell(o), > > it didn't take long for my recent patch for PR111781 to show a regression. > The fix proposed here is actually the one Harald posted in the PR. > I can't imagine a case where it wouldn't do the right thing. > Regression tested on x86_64-pc-linux-gnu. > OK for master? > Yes. Thank you (and Harald) for the quick fix. -- Steve