Re: [GOMP, Fortran] RFC: Issues with gomp-fortran tests

[Steve Kargl <sgk@troutmask.apl.washington.edu>]

Andre,

I have not seen an answer to your email.  I just built gcc/gfortran with
a build directory named objx/.  My 'make -j6 check-fortran' completed
without issues (other than the usual broken libsaniziter tests and
confusion of gmake versus make and $MAKE).  From your description, it
would certainly seem that the directory name gfortran/ is confusing the
dejagnu scripts.  If you haven't solved the problem, I'll suggest the
simple solution of choosing a different directory name.

PS: Welcome back to the gfortran effort.

-- 
steve


On Mon, Jun 03, 2024 at 03:38:20PM +0200, Andre Vehreschild wrote:
> Hi gfortraneers and gomp-specialists,
> 
> during regression testing I lately experience all OpenMP fortran tests to be
> failing. I do:
> 
> make check-fortran
> 
> My configure is:
> 
> ../gcc/configure --disable-multilib --enable-stage1-languages=c,fortran,c++
> --enable-checking=yes --enable-offload-defaulted --prefix=`realpath ../gfortran`
> 
> It does not matter, if I just do a stage1 build or a full bootstrap,
> fortran-gomp tests always fail. I haven't tried running the full testsuite,
> because that takes a loooong time. Trying to run only the target
> 
> make check-target-libgomp-fortran
> 
> (which is included in check-fortran), also results in the fortran-gomp tests not
> being run, or more specifically not being able to be compiled. In fact the
> gfortran compiler is not found. The expect scripts resolve the gfortran
> compiler for fortran-gomp-testing to be three levels up the directory tree,
> where a "gfortran" filesystem node is present, but is a directory. I.e. testing
> if something called gfortran is present there, will pass. Later on the tests
> then complain about "gfortran: Permission denied", because a directory - of
> course - can not be executed. I have spent two days now to figure how to resolve
> this, but all I came up with is this patch:
> 
> diff --git a/libgomp/testsuite/libgomp.fortran/fortran.exp
> b/libgomp/testsuite/libgomp.fortran/fortran.exp index 32e4bb2af4e..dd18aa98a91
> 100644 --- a/libgomp/testsuite/libgomp.fortran/fortran.exp
> +++ b/libgomp/testsuite/libgomp.fortran/fortran.exp
> @@ -20,9 +20,14 @@ if { $blddir != "" } {
>      } else {
>         set libquadmath_library_path ""
>      }
> -} elseif { ![info exists GFORTRAN_UNDER_TEST] } {
> +}
> +if { ![info exists GFORTRAN_UNDER_TEST]
> +        || ![file exists "$GFORTRAN_UNDER_TEST"] } {
>      verbose -log "GFORTRAN_UNDER_TEST not defined, will not execute fortran
> tests"
> -    return
> +    set GFORTRAN_UNDER_TEST "${blddir}/../../gcc/gfortran -B$blddir/../../gcc"
> +    if { ![file exists "$GFORTRAN_UNDER_TEST"] } {
> +       return
> +    }
>  }
>  if { $blddir != "" } {
>      set lang_source_re {^.*\.[fF](|90|95|03|08)$}
> 
> This is just a first shot. With the patch the test compile and run ok. But now
> my question: What am I doing wrong? I am working on gcc-master with only a few
> commits behind. Is testing libgomp-fortran fine for everyone else?
> 
> Regards,
> 	Andre
> --
> Andre Vehreschild * Email: vehre ad gmx dot de

-- 
Steve