public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH,FORTRAN] Remove OS dependency in definition of ASYNC_IO
@ 2018-08-23 19:03 David Edelsohn
  2018-08-23 19:27 ` Thomas Koenig
  0 siblings, 1 reply; 2+ messages in thread
From: David Edelsohn @ 2018-08-23 19:03 UTC (permalink / raw)
  To: GCC Patches, Fortran List

The recent fix for Async I/O on systems without Gthread cond support added
an explicit test for _AIX.  This test is unnecessary because
__GTHREAD_HAS_COND is not defined on AIX.  Protecting the use of
__gthread_cond_t inside in the ASYNC_IO macro for the declaration of struct
adv_cond is sufficient.  This patch simplifies the macro definition.

Bootstrapped on powerpc-ibm-aix7.2.0.0

Okay?

Thanks, David

* async.h (ASYNC_IO): Revert _AIX test.

Index: async.h
===================================================================
--- async.h     (revision 263818)
+++ async.h     (working copy)
@@ -29,7 +29,7 @@
    __gthread_cond_t and __gthread_equal / __gthread_self.  Check
    this.  */

-#if defined(__GTHREAD_HAS_COND) && defined(__GTHREADS_CXX0X) &&
!defined(_AIX)
+#if defined(__GTHREAD_HAS_COND) && defined(__GTHREADS_CXX0X)
 #define ASYNC_IO 1
 #else
 #define ASYNC_IO 0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH,FORTRAN] Remove OS dependency in definition of ASYNC_IO
  2018-08-23 19:03 [PATCH,FORTRAN] Remove OS dependency in definition of ASYNC_IO David Edelsohn
@ 2018-08-23 19:27 ` Thomas Koenig
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Koenig @ 2018-08-23 19:27 UTC (permalink / raw)
  To: David Edelsohn, GCC Patches, Fortran List

David,

> The recent fix for Async I/O on systems without Gthread cond support added
> an explicit test for _AIX.  This test is unnecessary because
> __GTHREAD_HAS_COND is not defined on AIX.  Protecting the use of
> __gthread_cond_t inside in the ASYNC_IO macro for the declaration of struct
> adv_cond is sufficient.  This patch simplifies the macro definition.
> 
> Bootstrapped on powerpc-ibm-aix7.2.0.0
> 
> Okay?

OK.

Thanks for the patch!

	Thomas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-23 19:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-23 19:03 [PATCH,FORTRAN] Remove OS dependency in definition of ASYNC_IO David Edelsohn
2018-08-23 19:27 ` Thomas Koenig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).