From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 6F6313858D37; Sat, 20 Apr 2024 13:05:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F6313858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F6313858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713618317; cv=none; b=nA58S4qb+MPx8X84iQc13u/2+KkJ4cijCE8B8cTH5d5HY8xXHidPLZFD7K0HjFVgUhUdYujErNoXYRkFUN/xdcbRpm4swadDjzgW2A9M3WjTfL6I83CoyB04fvKT0WtZdXPOli3YvsAGuPvXhjJp0xvXwsrhhHYhmbDFkfx+Y/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713618317; c=relaxed/simple; bh=bdBHIxrkvdvBunt7uqyOcWOdehNmf40QyJ4PHRA4s30=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Oc29jximGRddxBEkwn0QqG9GMdhMn/KM9FmevauEyIH7fdFMxy3YgGtYZlWT4ev7pGczKsmK3S+r++PMuzGAuXysmkdmYSyFvMd3lzITLV7gdTD89iPpQvMjpO4ox/fnKsNOFXnBw5bah9r2LGrKzqR7SIQtUDuLOfZT/wzwnCo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1713618313; x=1714223113; i=anlauf@gmx.de; bh=RvB+8H8QAQ1lbPqectwIhpls9S6Ql5z0TSr+3S+aueY=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=q0RQ+YnbOA5+YoLOy/pPbSyjFWZGcAq2m0idgD75hGySB+AMSRkO1Qnt0PR2kZQn 5ePzPCyFSxYrtOe2CS8MkEipsYPbEf5x1qWRN0Ez2P8g2I0+HfEPkVhBYMN8fsUgY jdO7QkjmqvHwIIvQgZJYyBwU6YRMj4A21ZBiedUpdOWQ5sXAa1ePlWlyNUl2Kd/mL 1hIwIURhsLVRIqYyRhPPjnwKryNL1AXjbMoOoUmkqJlAqb4krbzdijF18BAo5bfG2 0xTa0RvFvGolbxqfkNSO9BgmjMLj86u4VkpvM8U/rWxeyCpYW5sukviH9PVsqfADU HMjdbL6sYBxedYj+Zg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.80.9]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2mBa-1sjLc52GmS-01394p; Sat, 20 Apr 2024 15:05:13 +0200 Message-ID: Date: Sat, 20 Apr 2024 15:05:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch, fortran] PR103471 - [11/12/13/14 Regression] ICE in gfc_typenode_for_spec, at fortran/trans-types.c:1114 To: Paul Richard Thomas Cc: gcc-patches , fortran Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:rzI91jF6QRjv+qWE35qZzLlaze6spgumbZ7SkGy3tJaXqXM+qBf XHyknhhyYiG4SFQq3jxgKFs9hhWiySKe7gA7GzB22x5ggY9tVhKVnZBtGyMci8eHReHEIo1 cRanh37fDjix5AYBIscJEOihyTYQGSuIowIe7EOT5X1b+Wwa1iuyc87V3mp+9j0XMFItYph xUNpcyNruMtXJ5WfxUYNQ== UI-OutboundReport: notjunk:1;M01:P0:EeoyVkg3r0U=;mRn3KyXVaC4IS/AzWqnJWgnaH8g u2TRq4GzZU5kFKZGMER6xhNC6n6vR4sMIiRCbagEDOIS85Yo58mgsBF2Ngz80PLnQ/pcv6Tc8 EftVUM10N8XSiJhdPTb5Xc7cCR0hmg717CdpX4GIBdpvaIpbvzZvi3FVLKbdlqPyi4DEq2A+z lDxL5dI++BEEA8FFG//5iGLfnjNnqMutOcAjJ6DsF1ZcF3yCWTTJJQYqBJiMNfj/uF+dj4GcM hCAMkG1USH6dct4P4E911SXZRPcynhg3YOjd2tKEX8oUUBJp8NP8/hrFNOq7m+vUPT1GXau/G gWW4Km1mBcpVMj8gHDFVfJBnoPWb7ioT0tVBepbSWv2Zq7pE2psvuqQSf8ADLuPc2/CKrrMAi g2ZZEeOVWe4uWJl55Ov+mBPnm82Wg9p5QoooBaYh1N257a5aQr/QTm+6ruoVW2qLLHSNTaRx+ rSHlBdA0gQ+jigFYlxTUf9CzwpqPwu315FhJOCNBXopbXA0Zu0rrWCQ49oJ4jK2vOkvWJ1GAt NxqyWDXopYUojgPtpKAuFWnk0e2XRvbM4ZxgkOnMQaDfOvXFWzQ5ryPvN7K+2dpyaceCwtfdj em57m1TwnyWvwSWwiL+Jjsmy4Kwfg5XbEF9tOHY48EmVTXzcocAZMiBQeCxY8qyIfKnsubGLN JtG6o5nDloyKKfBc4wOHAhjJPQxGwu7VPfPgRv7dlNdyNcWVrdeZTirjeb++NDZmh3yE6oL2s IDsGmBXRPhMXdKixVxlVjpa9wjVQdVISS4bGP/9IQ8oI2u6MsbfbasnMF4axYzFxpNyJfVxyl JMDD80tFqzACj2DLRrMCQtO1j5CrrWT1H9Ir8uPQ+j+a4= X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul! On 4/20/24 09:54, Paul Richard Thomas wrote: >> subroutine sub >> implicit none >> real, external :: x >> real :: y(10) >> integer :: kk >> print *, [real(x(k))] >> ! print *, [real(y(k))] >> end >> > > This is another problem, somewhere upstream from resolve.cc, which I hav= e > just spent an hour failing to find. In the presence of both print > statements, in no matter which order, it is the error in trans-decl.cc t= hat > applies. Indeed, the gfc_fatal_error always wins. (I had tried to replace it with gfc_error()/return NULL_TREE, but then I hit an ICE later on. When trying to find out who added the said code, guess whom I found :) > >> Thus I have the impression that the testcase tests something different >> on the one hand, and on the other I wonder if we would want to change >> the error message and replace "no default type" to "no IMPLICIT type". >> It still would not hit the fuzzy check, but that is something that >> might not be important now. >> > > The fuzzy check was intended to ensure that the error was being detected= in > the "right" place. I want to keep the "no default type" message for the > time being at least so as to identify exactly where it comes from. Getti= ng > to trans-decl.cc with an unknown type is just wrong. True. > I'll come back to you on this. This PR is marked as a regression. Depending on your progress, it might be worth to consider fixing what you think is needed to get rid of the regression marker and defer the improvement of the diagnostics to a second patch. Harald > Thanks for the report. > > Paul >