From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17921 invoked by alias); 5 Jun 2016 22:28:33 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 17825 invoked by uid 89); 5 Jun 2016 22:28:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=jvdelisle@charter.net, jvdelislecharternet, Hx-languages-length:1253, HContent-Transfer-Encoding:8bit X-Spam-User: qpsmtpd, 2 recipients X-HELO: mtaout003-public.msg.strl.va.charter.net Received: from mtaout003-public.msg.strl.va.charter.net (HELO mtaout003-public.msg.strl.va.charter.net) (68.114.190.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 05 Jun 2016 22:28:21 +0000 Received: from impout002 ([68.114.189.17]) by mtaout003.msg.strl.va.charter.net (InterMail vM.9.00.023.01 201-2473-194) with ESMTP id <20160605222818.ZEPW23879.mtaout003.msg.strl.va.charter.net@impout002>; Sun, 5 Jun 2016 17:28:18 -0500 Received: from quattro.localdomain ([96.41.215.23]) by impout002 with charter.net id 3AUH1t0090Wrkg001AUHnR; Sun, 05 Jun 2016 17:28:18 -0500 X-Authority-Analysis: v=2.1 cv=EbdGQZWC c=1 sm=1 tr=0 a=salB9WdMPIDduBH7JsZfrA==:117 a=salB9WdMPIDduBH7JsZfrA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=hOpmn2quAAAA:8 a=mDV3o1hIAAAA:8 a=g8bV_CAXIheKQrofiyoA:9 a=QEXdDO2ut3YA:10 a=GyA-uvUxXSCciAkwuKQO:22 a=_FVE-zBwftR9WsbkzFJk:22 X-Auth-id: anZkZWxpc2xlQGNoYXJ0ZXIubmV0 Subject: Re: [patch, fortran] PR52393 I/O: "READ format" statement with parenthesized default-char-expr To: "H.J. Lu" References: <56bf245f-7f72-7f90-f9b6-c5aa0e5e5fd7@charter.net> <3F336BB9-A24D-4B1E-8E98-25DBC1246326@gmail.com> <510ebfd6-3e3c-c75b-e5d5-1328ebc28351@charter.net> Cc: FX , gfortran , gcc patches From: Jerry DeLisle Message-ID: Date: Sun, 05 Jun 2016 22:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00018.txt.bz2 On 06/03/2016 12:40 PM, H.J. Lu wrote: > On Wed, Jun 1, 2016 at 9:28 AM, Jerry DeLisle wrote: >> On 06/01/2016 12:25 AM, FX wrote: >>>> 2016-05-30 Jerry DeLisle >>>> >>>> PR fortran/52393 >>>> * io.c (match_io): For READ, try to match a default character >>>> expression. If found, set the dt format expression to this, >>>> otherwise go back and try control list. >>> >>> OK. Maybe you could add some “negative” tests too? To be sure we still catch malformed parenthesized formats? >>> >>> FX >>> >> >> Thanks for review! yes I will add some tests. >> > > It caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71404 > > Patch committed. Author: jvdelisle Date: Sun Jun 5 19:49:59 2016 New Revision: 237108 URL: https://gcc.gnu.org/viewcvs?rev=237108&root=gcc&view=rev Log: 2016-06-05 Jerry DeLisle PR fortran/71404 * io.c (match_io): For READ, commit in pending symbols in the current statement before trying to match an expression so that if the match fails and we undo symbols we dont toss good symbols. Modified: trunk/gcc/fortran/ChangeLog trunk/gcc/fortran/io.c