From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 9B58B3858C52; Thu, 29 Feb 2024 17:36:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B58B3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B58B3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1030 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709228207; cv=none; b=eJnblbZS3fxM5P/qM/9orY27dL2xIjb/yg8hqEbjKCTtsARodnlQXmSQM79HKEvBNhPr55RFps0Tw4t6lZBYczyGN0sIH63rXsn68iGMNBubnPIkZfP71u+i1jifGOElD2ipnZGbv7+0La+WVJ//pUlO7xhthd3EMFMaiwKGzN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709228207; c=relaxed/simple; bh=ZgDhXV+hYWSjc7I9CkkGQIXvvrwPa1iphlU7ujZfQxQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Eucar8My2tRxZnauQPhmpujaKz6OYUbO2ExWjESM/qfKPOVle2lXEaHgP2vEuDjMQUpNsaGR4MsCWKw4E35H9m0e7kanYhbscosAtsm/AUlG0p+KVWUf2RtErNAAOc2/NpbTAZwJM9DZ7Y8OCVQnOp11pm3tmtt1SrkC6YoUjAE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-299caf9b13fso69729a91.0; Thu, 29 Feb 2024 09:36:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709228204; x=1709833004; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cdpul1oe9s4FAKfqebl0TvGj4r7sxLWlhHws3nPB1vs=; b=mSmA3e8FwMwJYOAU8/sgI+9j+llIjDcM58M1OXY6S/xDhQPUTh4v5apwMV7lXFeNrA sQO7dGsluPkI+OM77ZSoQyGYV7FJfAzCi/S+8Gf/kpqh4NcERRkWcDkQzKJJlqdYXQEG lUAUPtIcjSgnHyxg43jg8nLiALfyg2xvM3jZ2dPyUcx76UOgnUH2Kfp6P1vI7kKn544p 5KrqCHx8rIqAKUZFyhW2GT4KTwPJBhihZibu4riL6VLra9fFbW7XYwzCQhSUro9b+pjO XdWreUNPnbmka4Q0juxd2Uw1jSnHmbi+/pKCY9FdRih4+d5XAgH4wkOgu4ATPykgUM1Y XU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709228204; x=1709833004; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdpul1oe9s4FAKfqebl0TvGj4r7sxLWlhHws3nPB1vs=; b=b2+KRS3Q+/o76DRNIF5iLRT6HPGzki/eaeg9hI9gONwk5d+3eqV4pLGbSzEbHJEeLD SIQw9YbfImgSR3HroZE5RqVUpuWFMt/7QVa7eIgTm1LJuVfHe+iCTfhN7vgzIzgi1k4Y pHLmTjGGA0QEOi8C8mIWR30jUg8LEfAz42zx97wZwYnqS4jZQ2/KLt58O0+BQNBTavXb +X5tdv3GsIyVtOGJnghOLZP1gWlGXpWZlvEys41jiCSRbjju61vFEflDdZzqwPbhgNYr 8HBaGVnLUt6gdIo8hIXdAopqxj66wg73ldnByIY3n7KRiGSn7ljdz8TU8LjGhawNIQqW UiAA== X-Forwarded-Encrypted: i=1; AJvYcCUlKBzElkXQ0N2dwLeleQm7R2XH1vRSnuq5zxdcVVWTdUGP9tKO129aCiZ+S+rvKs1V6ogk+g9Hcp9el2vw33GvLHqEUDFC0A== X-Gm-Message-State: AOJu0Ywzfavs6vPapIEOi5tmpLTYP7oF0+thdCMHX/sLyLhqq0Uc9CXZ Y2gr69xIBZ+2dwOXdvwTmKX4HK4tDD8TFoA+zaXhMrl7uVA+Ivm8b1tSHH0j X-Google-Smtp-Source: AGHT+IG5rkiITv/yzTg9sCWZvB8WMgT8Sxhw4VMfejEsV+aCTIzWSI7bFkmijYL9CoLrOX+Se7+ruQ== X-Received: by 2002:a17:90a:d251:b0:298:bc90:3b69 with SMTP id o17-20020a17090ad25100b00298bc903b69mr2818201pjw.3.1709228204424; Thu, 29 Feb 2024 09:36:44 -0800 (PST) Received: from [192.168.1.20] ([50.37.177.113]) by smtp.gmail.com with ESMTPSA id v19-20020a17090a899300b0029951d04dc4sm1702017pjn.54.2024.02.29.09.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 09:36:44 -0800 (PST) Message-ID: Date: Thu, 29 Feb 2024 09:36:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch, libgfortran] Part 2: PR105456 Child I/O does not propage iostat Content-Language: en-US To: Bernhard Reutner-Fischer Cc: gfortran , gcc-patches References: <943c3685-c4d4-4f22-8b65-6336f8770043@gmail.com> <20240229104705.62e46010@nbbrfq.loc> From: Jerry D Autocrypt: addr=jvdelisle2@gmail.com; keydata= xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc= In-Reply-To: <20240229104705.62e46010@nbbrfq.loc> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/29/24 1:47 AM, Bernhard Reutner-Fischer wrote: > On Wed, 28 Feb 2024 21:29:06 -0800 > Jerry D wrote: > >> The attached patch adds the error checks similar to the first patch >> previously committed. >> >> I noticed a redundancy in some defines MSGLEN and IOMSG_LEN so I >> consolidated this to one define in io.h. This is just cleanup stuff. >> >> I have added test cases for each of the places where UDTIO is done in >> the library. >> >> Regressions tested on x86_64. >> >> OK for trunk? > > I think the commit hooks will complain about several missing spaces > before open brace; See contrib/check_GNU_style.py /tmp/pr105456-3.diff I was given the OK from git gcc-verify. Regardless if hooks fail I just fix and try again. > > Would it make sense to introduce and use an internal helper like trim()? > Or would it be possible to trim the message in generate_error_common()? > I was debating this and what would be the best approach. I was not sure where to put it. I like the idea of doing in the generate_error_common. I will try that and see how it plays. > And, just for my own education, the length limitation of iomsg to 255 > chars is not backed by the standard AFAICS, right? It's just our > STRERR_MAXSZ? Yes, its what we have had for a long lone time. Once you throw an error things get very processor dependent. I found MSGLEN set to 100 and IOMSG_len to 256. Nothing magic about it. I appreciate the comments. --- snip --- Jerry -