* [committed] gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail
@ 2021-06-04 11:20 Tobias Burnus
2021-06-04 11:32 ` Tobias Burnus
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Burnus @ 2021-06-04 11:20 UTC (permalink / raw)
To: gcc-patches, fortran, Jakub Jelinek
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
This adds a bunch of 'implicit none' to the testcases,
a missing 'integer i' and fixes a typo in a loop variable,
which permitted to remove an xfail.
Currently, there are two classes of xfail:
* !$omp parallel master taskloop (simd)
→ parallel misses shared(...)
for firstprivate/lastprivate/reduction variable
* !$omp target ...
→ Missing 'map(tofrom:'
for firstprivate/lastprivate/reduction
→ Wrong firstprivate in that case
Committed as r12-1210-g78b622e37381e1c0e9992f6634972dfbe0338d0b
Tobias
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
[-- Attachment #2: committed.diff --]
[-- Type: text/x-patch, Size: 4853 bytes --]
commit 78b622e37381e1c0e9992f6634972dfbe0338d0b
Author: Tobias Burnus <tobias@codesourcery.com>
Date: Fri Jun 4 13:10:57 2021 +0200
gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail
gcc/testsuite/ChangeLog:
* gfortran.dg/gomp/pr99928-1.f90: Add 'implicit none'.
* gfortran.dg/gomp/pr99928-11.f90: Likewise.
* gfortran.dg/gomp/pr99928-4.f90: Likewise.
* gfortran.dg/gomp/pr99928-6.f90: Likewise.
* gfortran.dg/gomp/pr99928-8.f90: Likewise.
* gfortran.dg/gomp/pr99928-2.f90: Likewise. Add missing decl.
* gfortran.dg/gomp/pr99928-5.f90: Add implicit none;
fix loop-variable and remove xfail.
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90
index 5cbffb09b3f..e5be42fba53 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-1.f90
@@ -3,6 +3,7 @@
! { dg-options "-fopenmp -fdump-tree-gimple" }
module m
+ implicit none
integer :: f00, f01, f02, f03, f04, f05, f06, f07, f08, f09
integer :: f12, f13, f14, f15, f16, f17, f18, f19
integer :: f20, f21, f22, f23, f24, f25, f26, f27, f28, f29
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90
index 864ae4b6c99..22a40e2b49c 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-11.f90
@@ -3,6 +3,7 @@
! { dg-options "-fopenmp -fdump-tree-gimple" }
module m
+ implicit none
integer :: r00, r01, r02
contains
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90
index 5dbf78ba291..fe8a715279a 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-2.f90
@@ -3,12 +3,14 @@
! { dg-options "-fopenmp -fdump-tree-gimple" }
module m
+ implicit none
integer :: l00, l01, l02, l03, l04, l05, l06, l07
integer :: l10, l11, l12, l13, l14, l15, l16, l17, l18
contains
subroutine foo ()
+ integer :: i
! { dg-final { scan-tree-dump "omp distribute\[^\n\r]*lastprivate\\(l00\\)" "gimple" } }
! { dg-final { scan-tree-dump "omp parallel\[^\n\r]*lastprivate\\(l00\\)" "gimple" } } ! FIXME: This should be on for instead.
! { dg-final { scan-tree-dump-not "omp for\[^\n\r]*lastprivate\\(l00\\)" "gimple" } } ! FIXME.
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90
index 5b82dd6581c..ead8f030e63 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-4.f90
@@ -3,6 +3,7 @@
! { dg-options "-fopenmp -fdump-tree-gimple" }
module m
+ implicit none
integer :: l00, l01, l05, l06, l07, l08
contains
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
index 9f45e48feb4..c612aaf9556 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
@@ -3,6 +3,7 @@
! { dg-options "-fopenmp -fdump-tree-gimple" }
module m
+ implicit none
integer :: j00, j01, j02, j03, j04, j06, j07, j08, j09
integer :: j10
@@ -85,9 +86,9 @@ subroutine bar ()
end do
! { dg-final { scan-tree-dump "omp taskloop\[^\n\r]*shared\\(j10\\)" "gimple" } } ! NOTE: This is implementation detail.
! { dg-final { scan-tree-dump "omp taskloop\[^\n\r]*lastprivate\\(j10\\)" "gimple" } }
- ! { dg-final { scan-tree-dump "omp simd\[^\n\r]*linear\\(j10:1\\)" "gimple" { xfail *-*-* } } }
+ ! { dg-final { scan-tree-dump "omp simd\[^\n\r]*linear\\(j10:1\\)" "gimple" } }
!$omp taskloop simd linear (j10) default(none)
- do j010 = 1, 64
+ do j01 = 1, 64
end do
! { dg-final { scan-tree-dump "omp teams\[^\n\r]*shared\\(j11\\)" "gimple" } }
! { dg-final { scan-tree-dump "omp distribute\[^\n\r]*lastprivate\\(j11\\)" "gimple" } }
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90
index 37a93e6b1ac..0e60199476b 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-6.f90
@@ -3,6 +3,7 @@
! { dg-options "-fopenmp -fdump-tree-gimple" }
module m
+ implicit none
integer :: j00, j01, j02, j03, j04, j06, j07, j08, j09
integer :: j10
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90
index de27ffed629..a5b028b564d 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-8.f90
@@ -3,6 +3,7 @@
! { dg-options "-fopenmp -fdump-tree-gimple" }
module m
+ implicit none
integer :: r00, r01, r02, r03, r04, r05
integer :: r13, r14, r15, r16, r17, r18, r19
integer :: r20, r21, r22, r23, r24
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [committed] gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail
2021-06-04 11:20 [committed] gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail Tobias Burnus
@ 2021-06-04 11:32 ` Tobias Burnus
0 siblings, 0 replies; 2+ messages in thread
From: Tobias Burnus @ 2021-06-04 11:32 UTC (permalink / raw)
To: gcc-patches, fortran, Jakub Jelinek
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On 04.06.21 13:20, Tobias Burnus wrote:
> This adds a bunch of 'implicit none' to the testcases,
> a missing 'integer i' and fixes a typo in a loop variable,
> which permitted to remove an xfail.
Or actually it didn't, as I seemingly did a last-minute change in the
wrong way after running the testsuite or missed a 'git add' or ... :-(
The xfail is fixed – but only with this follow-up commit
r12-1211-gad3f0ad4bafe377072a53ded468fd9948e659f46.
Tobias
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
[-- Attachment #2: committed.diff --]
[-- Type: text/x-patch, Size: 713 bytes --]
commit ad3f0ad4bafe377072a53ded468fd9948e659f46
Author: Tobias Burnus <tobias@codesourcery.com>
Date: Fri Jun 4 13:26:40 2021 +0200
gfortran.dg/gomp/pr99928-5.f90: Use proper iteration var
gcc/testsuite/ChangeLog:
* gfortran.dg/gomp/pr99928-5.f90: Really use the
proper iteration variable.
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90 b/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
index c612aaf9556..49cbf1e8cc2 100644
--- a/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/pr99928-5.f90
@@ -90,3 +90,3 @@ subroutine bar ()
!$omp taskloop simd linear (j10) default(none)
- do j01 = 1, 64
+ do j10 = 1, 64
end do
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-04 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 11:20 [committed] gfortran.dg/gomp/pr99928-*.f90: Use implicit none, remove one xfail Tobias Burnus
2021-06-04 11:32 ` Tobias Burnus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).