From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tkoenig@netcologne.de>
Received: from cc-smtpout2.netcologne.de (cc-smtpout2.netcologne.de
 [89.1.8.212])
 by sourceware.org (Postfix) with ESMTPS id 20D47384D191;
 Fri, 24 Jun 2022 13:58:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20D47384D191
Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202])
 by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 835BF12460;
 Fri, 24 Jun 2022 15:58:26 +0200 (CEST)
Received: from [IPV6:2001:4dd7:3fa9:0:7285:c2ff:fe6c:992d]
 (2001-4dd7-3fa9-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de
 [IPv6:2001:4dd7:3fa9:0:7285:c2ff:fe6c:992d])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA id 1540311DFD;
 Fri, 24 Jun 2022 15:58:21 +0200 (CEST)
Message-ID: <a7719202-216c-f565-8324-c817f6077f0f@netcologne.de>
Date: Fri, 24 Jun 2022 15:58:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 6/8] fortran: use grep -F instead of fgrep
Content-Language: en-US
To: Xi Ruoyao <xry111@xry111.site>,
 Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
References: <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site>
 <3fe5664607c4e530fbb91048c2e363ddee917250.camel@xry111.site>
 <20220624131331.0b157480@nbbrfq>
 <09114af24f7f09eb2fa6c7dc743de18480d8bd7d.camel@xry111.site>
From: Thomas Koenig <tkoenig@netcologne.de>
In-Reply-To: <09114af24f7f09eb2fa6c7dc743de18480d8bd7d.camel@xry111.site>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-NetCologne-Spam: L
X-Spamd-Bar: /
X-Rspamd-Queue-Id: 1540311DFD
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A,
 RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
 SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: fortran@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Fortran mailing list <fortran.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/fortran/>
List-Help: <mailto:fortran-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jun 2022 13:58:30 -0000

Hi,

> On Fri, 2022-06-24 at 13:13 +0200, Bernhard Reutner-Fischer wrote:
> 
>>> -       if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \
>>> +       if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v -i debian' >/dev/null 2>&1; then \
>>>            echo " install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info"; \
>>>            install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info || : ; \
>>>          else : ; fi; \
>>
>> I'd replace -s >/dev/null 2>&1 with -q while at it.
>>
>> But why is -F used here in the first place?
>> I do not see much in debian that can be interpreted as a regex?
> 
> I'm not sure.  It was there since 2004.  Perhaps the author thinks fgrep
> may save several CPU cycles :).  I'll just use a plain grep in PATCH v2.
> 
> Rainer: do you have some idea about the availability of "-q" on
> different hosts?  If you agree I'll use it instead of -s > /dev/null
> too.

Is there any particular reason why we should not use the result of
AC_PROG_FGREP ?  AC_PROG_GREP should also work.