From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 764A23882100; Fri, 14 Jun 2024 19:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 764A23882100 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 764A23882100 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718394232; cv=none; b=vSYBl1f/QLY/Vs2EUAJ+GkGXhil6OT0u6FCwgTVNOpVmfcxVg0p8OOREW8sUB1oNPvyoO6CuVnTcYgA5RtCdO6UEIpOTaUoFbUNYvOGzqrecQ/Gui5xbn+Owrn/sNOm9wB7kLFFdKklIDP3tGFfciCeJ5kuY0rm7Cu0m0SRZZkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718394232; c=relaxed/simple; bh=aDs0iTZgGTGwNmTqmt9cqrqc7SoqhY216g/A8Qagk40=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Sls5s+QqSMD5cQiwKI/DCzk+t5ZQLAVgw1qTTGP8Y50Xi4fhy9BJP4hfkv9h8Rk+QAIbBP75aTH1cvQ9OPFcCLmjNDbgNyUqPnxYPrQtJLcejcZXzB90hX6yEU/PZnlUQkiMMCZ9FJnvOiE0m68DZJbSOBic1EBs8GCGB+8WAUE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1718394229; x=1718999029; i=anlauf@gmx.de; bh=+UBBHCIWUntMXBwHY4l7rtFaOjOBWC3C3JzUb3q8xKA=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=bOl2o19TQNEBBW3DlDdVLEYlBjzWGL7ACs5gB8TKRJVMwG6/pUNYnSZcOjIeDiuT 851YpEkUBzRzVkqJ1FMBG632+dSX62CjjXncj369Tmo484LOc/Ui3i0MuYigBBpDm /jJlHZyeLAwXdgHlev42G5fqfsyqzx6IYPd+q5yLnqEyHnpNZtezaXoILkvqKgiwx /cMhM1X/8554NHIDUwKE0Lg0kgx2YhqDm1uzAIEXyJEzUWgUhDLWOPTsK3pda+8hN dExrZkuGVAaH4z3qR7ZtzwSl/bziJHSbQIcfYxy7rnCNbuCDe3GyunmkfuvqLpv7y xIvea9URpvrGVNoERg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.232.145.9]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MulqD-1saYw20cD5-00sCeB; Fri, 14 Jun 2024 21:43:49 +0200 Message-ID: Date: Fri, 14 Jun 2024 21:43:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs To: Andre Vehreschild , GCC-Patches-ML , GCC-Fortran-ML Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <20240611161238.14634f57@vepi2> <20240614092256.48442c03@vepi2> Content-Language: en-US From: Harald Anlauf In-Reply-To: <20240614092256.48442c03@vepi2> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:nj5mZtJZTZb1MEwnFctZQFWPTpngjxJQYCtbWh4zQhx66D519OW kFQm7bdXxRTVb2ziB6X0M96aCvuHwMQL1heti/LEHTcb/LZrWBMAOLoP6Aj31tSlCkJosPu 6WwB8KMN1AVcIZWSFn53vdQ9DDppEHH0HTRpPdV9VgvkBEEsY1GES6VH/2Xa+VQwQfWccOU ivKFQBL150ee8zMYZygIw== UI-OutboundReport: notjunk:1;M01:P0:FfBxGFYIYKU=;nHy7bqBVIfYWyhKP/P5UZMFWQWo NGI6HDrBpMY0BcWqjEBZF1xbFnLxr3n63QevivXIJilBNlU7kEwudRAB3uGId0Xtl+bhaB/KY btQq7yCyZXAQJN5LTVUEuA/sRqg4CSztNolDPCfFcvcv3FZbY/OaIjaTiQiKYZHPX0uRHHygq 7XsVtrTTN+ZSvMuHW2Da6GDpUkQbNSJRy7uxcn0KurwZBgw8eXMqvk6KnJ8ztPQ/tjAghKt74 P4GfX5WGTI+3CsSlc91UQyBGa7xEhY1yyE7wWiiiPdQHIjhkuWen2HBxkXlRLxf5KQwRv7u5e ibz//7jtxg7Oyvr+CofiLcshhK65ZGKGQ2VRso43efVIiopXITUk+kb3Eq+SsRnw/4jFKAFZJ p4rTDVSWyNXHZ9ShMs4wHoczs2h0hvgBoMbbOpJEwyZ/umotS1d2HkdC/fh0S0AkXS9SsUkvj pjLCnTe/8zl4pphzgh6haZhp9jJviIy8aXnow1Qxh0A0CeCXVZDcnJVA70+w9gKKkj1oY7TOm Osnzk+lqJiorxQMmn1kDMOEEz7vN2us6KqCjC5M//XjvlNHyFfifMkcj1+YGnMN4hVDhz5zV7 RQFVtF4ggPRxaueeK43AyxIlIDyh4JexdPz0AY66T0USyeufaaYzcG+WoY31i9TzWfwvzg7ep AccdokJKtHeGOMqNzIfrcPJ7BFKcjXjjAgcJHa83zu61yHO3rZyydVjjJEu3pKVhZbBiE7uKa PLHItVth09AH/5LrnvDdOsnJYGrk1YSTzXmO6O04vCcCq4CEZmugO2F/vCAVnXskGblTe8VnO GLWJFl2b1kMwN9ZvY8TE1eLOo57JhdXM+Iy77YzppQFLU= X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andre, the patch looks fairly simple and obvious, so OK from my side. *** Regarding the testsuite: since you renamed one of the testcases gfortran.dg/coarray_alloc_comp_* and moved it to gfortran.dg/coarray/, I checked and noticed that there are other similar runtime tests for coarrays (while some are compile-time only tests). Do we plan to "clean" this up and move more/all related runtime tests to the coarray/ subdirectory? What is the general opinion on this? *** Thanks for the patch! Harald Am 14.06.24 um 09:22 schrieb Andre Vehreschild: > Hi all, > > I messed up renaming of the coarray_alloc_comp-test. This is fixed in th= e second > version of the patch. Sorry for the inconvenience. > > Additionally I figured that this patch also fixed PR fortran/103112. > > Regtests ok on x86_64 Fedora 39. Ok for mainline? > > Regards, > Andre > > On Tue, 11 Jun 2024 16:12:38 +0200 > Andre Vehreschild wrote: > >> Hi all, >> >> attached patch has already been present in 2020, but lost my attention.= It >> fixes an ICE in the testsuite. The old mails description is: >> >> attached patch fixes PR96418 where the code in the testsuite when compi= led >> with -fcoarray=3Dsingle lead to an ICE. The reason was that the coarra= y object >> was derefed as an array, but it was no array. Introducing the test for = the >> descriptor removes the ICE. >> >> Regtests ok on x86_64-linux/Fedora 39. Ok for mainline? >> >> Regards, >> Andre >> -- >> Andre Vehreschild * Email: vehre ad gmx dot de > > > -- > Andre Vehreschild * Email: vehre ad gmx dot de