From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 0814A3858CDB for ; Mon, 25 Mar 2024 20:52:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0814A3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0814A3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711399958; cv=none; b=FmsxOeWvb3NkjYVyW+1VXyiB4caD3jkZR1j1DL5e/IMxeglXAxfRdnsulZT38Sa4okjpkXemxeQCQABhA0jXsPKkT1KG9TI8HgC3wNDec26PdQhk6hw5DXSe5o+tHav871YLgFUwGkotGNm537sfA62tJXF0GIyc7CGYl7wyo9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711399958; c=relaxed/simple; bh=oG73p7zzhFpeYJ3aw/aZdUZBG4UgEEArhfQLsdPSQ0c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gEfYUqtAeX1ZRtZDZxTW4qOe7hyHV1mm9+D2jbcNedaH3RN3O/UTdEwik10H2vqeOCWydh5mZF0DyJVZacEARq7yMLydwAiTp79mKCiOU6cc3gramYdlWUaw4ELQ8DILFGCu5qTV9VxXHQFCNVsZhpy+fX892+qhJlrsRntQx+o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6e6c38be762so382407b3a.1 for ; Mon, 25 Mar 2024 13:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711399956; x=1712004756; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=daXOqlEBFsnsyK975wLIjcvNix5Ns1IkdHlR/PWsbDg=; b=gMnr2nKzSsxkni3hiATMurbjRlESPoPm6j94alfQeQ4f1+8cVLpjS0HhK3kO9lMXRV F2nuZvSPmXHgP5DhUf5bUBuK1aFOiqt1XL0JHWNfX5o1BWPViHuFAXX539kbCxEV7wmQ aI+RQ2sKjelHG4Z1eU496exeb6xDwMKo5XEuApi8CGmCYxJlFT3VNf+MQaOICwWKzD6h czY4i+JMI96ugBhV+QG6+lkUz9X6qW/asfAg0PcaIx4UH17hEHMoFalvu1SCBrBpPJjH GQgpIs98AMImf729CIxnElix95pUVBhIK6tPzxltWdM89Jfa+QqhOwh2RpGZMnUJ6Ytg C9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711399956; x=1712004756; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=daXOqlEBFsnsyK975wLIjcvNix5Ns1IkdHlR/PWsbDg=; b=QZ4XIUswaNEgZvUwhINhi2DcgPmYmnAbw6MEuyjNoIDpfjWEgOFOuaOjTDEqPMLvze I62kFS9KPgJVU9H7MCCJbWNFEnnOWlbweFyEPCbh/HZ+AUtLh9zlT32cnvltXZkLbflN TYW5+pgPAiLnc0Ur8k/F/1hX85DxCRRWAvrBs21ztwVP5QMitnMW8Wo8y1Kr/GvbvAma jOTjcwgXuHaAFxCM9iaUwF/bsdAkte5JNb2nteFJbGHvFdEx55HLaeoUcKXCLv+xVUCh q7qYmCScHbSaXjEy7W6VtFfQNu9Wrod7ZInElqQz/K6KfopddqDZgjh8u8AT0rSr7raB 8y5g== X-Forwarded-Encrypted: i=1; AJvYcCWdocai9PWSvlqvr9ov3JsVS9OaE5aotxSJxPoC9wCqRPNbOC08esT1obBy0QG1gGRaJeTOtWjbM4EmVbMwUCxob4hR X-Gm-Message-State: AOJu0YzqkF1BE7XwNIBjL47EZ1GdJWAiOfrm0Bit5s7Zc0vOEplTFfhf 8AtDd+hcmSiWLN1M0pyP/7H6Nx5HJ/qwAn8s1envpLY0sSxEdYQx X-Google-Smtp-Source: AGHT+IHbWAD8jI9EOv+Do/gQqINiY3uvwOZLjRXe0aZ0UotFK4U9dAfGK8Y8Q/eWMDjYBgLXS+7A9A== X-Received: by 2002:a17:90a:b016:b0:29b:ef73:44ff with SMTP id x22-20020a17090ab01600b0029bef7344ffmr6971353pjq.1.1711399955786; Mon, 25 Mar 2024 13:52:35 -0700 (PDT) Received: from [192.168.1.20] ([50.37.177.113]) by smtp.gmail.com with ESMTPSA id d12-20020a17090b004c00b002a076b6cc69sm1560142pjt.23.2024.03.25.13.52.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 13:52:35 -0700 (PDT) Message-ID: Date: Mon, 25 Mar 2024 13:52:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Invalid "dg-do run" in the testsuite (with 2 blanks) To: Harald Anlauf Cc: Manfred Schwarb , fortran References: <9f140118-0327-4d2b-aa07-12508263a1c7@gmail.com> <30b68ddc-3233-4ece-9df8-b2ad93800686@gmail.com> Content-Language: en-US From: Jerry D Autocrypt: addr=jvdelisle2@gmail.com; keydata= xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/25/24 12:53 PM, Harald Anlauf wrote: >>>>> I noticed by chance that we have quite a lot of improperly specified do-do >>>>> directives in the testsuite. >>>>> >>>>> % grep "dg-do  run" gcc/testsuite/gfortran.dg/ -rl|wc -l >>>>> 83 >>>>> >>> >>> I think this is on purpose. >>> The idea to use a "feature" in dejagnu to only iterate once and not >>> over all possible options. So execution time can be lowered a bit. >>> >>> But I don't know if this hack still works, it definitely did work some years ago. >>> >>> Cheers, >>> Manfred > > Is this "feature" documented somewhere? I don't see it on > > https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gccint/Directives.html > > Given that the dg-directives are important and possibly fragile, > and since we had issues in the past, can we check that a test > that was added works the way intended? > >>>>> Note that with two blanks instead of just one a testcase does not get executed. >>>>> >>>>> Does anybody want to earn the honors to change the directives and >>>>> check for "fallout" in the testsuite? >>>>> >>>>> Cheers, >>>>> Harald >>>>> >>>> >>>> One failure after fixing all the spaces ( sed is our friend ). >>>> >>>> FAIL: gfortran.dg/inline_matmul_1.f90   -O0   scan-tree-dump-times optimized "_gfortran_matmul" 0 > > This does actually point to an issue with the testcase: > it only works properly with optimization enabled. > > Manual inspection of this test and the expected dump suggests > that e.g. -O1 could have been added to the dg-options directive. > > Shouldn't we fix at least the dg-options of that testcase? > > Cheers, > Harald > I restored the one test that appeared to fail so that it had the two spaces 'trick'. When run in the test suite, it is compiled with -O which does invoke the optimization. I manually checked the tree dump with this option and it indeed has all the _gfortran_matmul calls removed. I am inclined to leave these all untouched with the two spaces in place. From the test log: PASS: gfortran.dg/inline_matmul_1.f90 -O execution test PASS: gfortran.dg/inline_matmul_1.f90 -O scan-tree-dump-times optimized "_gfortran_matmul" 0 Regards, Jerry