From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id C45773858D33; Tue, 27 Dec 2022 11:04:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C45773858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1672139047; bh=llvwnSILDxMcwGnVCiYJQILBaSpfH7ypJ1gjB7DRdXo=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=m5zUI/D0AAhjhwn/FkMGWAcLFem7Cw7vkGJkTfPNz5NYkGM+c8B++tFA4umIjZzCC xbRYMwOhh52WcZVp2GQLm0CVkK83WiQEvKmckfd75UBwbq4K0qMwHDNMF7f2mRWLdj VEIOdxLP6xLHWaoOuGD+ZhgKeB4J/fIAMyWiuohdt+z4U7rr/jIcMswVgpiWlzZW2E +PvIhHYTxy+G3Jku4AkwAOmZEm9Gc4xUTj+P5pue0iinu85O2FQnbwo64yei1ZHS+y TZEg8Ytth1iL83LaUnInWVEGm1yf++SD8w84WDpmqebog7031yed5ifbjpeFTRRsiE 6gOcPgU5m/icQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.82.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MF3He-1p3YAp0ehk-00FWkO; Tue, 27 Dec 2022 12:04:07 +0100 Message-ID: Date: Tue, 27 Dec 2022 12:04:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [patch, fortran] ICE in attr_decl1, at fortran/decl.c:8691 To: Jerry DeLisle , gfortran Cc: gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <7802b3ba-cf1d-84eb-6e64-e470ef8e911a@protonmail.com> Content-Language: en-US From: Harald Anlauf In-Reply-To: <7802b3ba-cf1d-84eb-6e64-e470ef8e911a@protonmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3oUOYw5vv7KsfNQc7JA+hi5/KLyhjnAhoNFchkzTmKU/bLKmc7D zXioMtXLBZi9FaSF813l1EMsF6XFUzgbbpjYyeWx4ytmXD2OdeibDtka538xJbXJ4hqZa0q 6HzzwvMrfEvbtHDT6geKN0eAMEmseUkKq2vQeJEmMAbMEsPdk+GAm16wNti4xDndaGBgLwJ Nhy7SX850at1tI9ihU/1w== UI-OutboundReport: notjunk:1;M01:P0:f7nqbdHVvIw=;0ozX5nfUXga8UpZbRtVKRd1jfa9 deqhG8SB+id+03ES65FA6lcawACt87LsCd/bnX5LYy8YYajOdtjzjt5la4PdefX5HxI3fqbRW Ft+BpDLgyqILkz+cldVo+WKYPdNMCQ2gWqnTAm+rKQjzFd1qG/RtgZy4MPhlQDeVp35TSbcJC /JsFv2Br3o4m9aU9l/2iE6vK3xygTaQv2K9wqM93MgGARCwjOGF0uu7OnIvcwx+OgOwEz18HX 3yDtgXNVyGiVtNFdCNSbju8O+bZSXT+/k6u10GX6AvOEHjN0wCFTX/rD+PT6wuWhmOtILpqEX 4q4cLwTPYM7KafMtwf4P+shxnaym5W9w29iRLisBNb9kZPM1owgMTkB4QycMrGW8VQRqZj8zv F/TV59jminK7sV9gFb7bJtceawRb7lz+rts3HyCdSa6D24m/EozmEg6BZ7E6Bth1vsvOFKK4d zw2Ee2ymOSicupWkxBCQvPofNmnYJdxyVIVIzX8VYCyALqf2TLLAmdgv9BlY9CF1/jyYX6m3I GH96LjQUJ3Z0LigE2ZX/W3AIKXGUSrJBBGQ7z3j6uNX4QfeMj17cjPc2ltV/nJL0VaNV35on7 gsibG6sBEM+Qsj+Np1lQreZdY4KCXyNMhUdEKytTl7m8j0sYJcYhqQCkWXTqUwRbBerbzNLAA 6lPjdIuBYIGf3Spc8v+YN2gzl8A2ELvBeHT+KYvSX1Hfpz/VGAW2tIMuV34zHQ02fpeKe3exA h76GldcR8wBN73qgswdGu9ME7KGMrFHprMYl/Ya35DRkjEYzLOj5XyT+xQ2i/MzdLkWrChwfR Ui3AQx3syQn2W16SsPNRUtDhOh1bzP9EMIvxiH7XiaNDEBtrOiuWvmMBi335uUnsGZ5I1LDZ1 JGj0ZTdsu/vw9UdIdxAMa7dI1L3gix88jSHywm61jAU4oO18mbJrlOFkMqyrh9NijFOM0vaMr OvMZaA== X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jerry, Am 26.12.22 um 23:26 schrieb Jerry DeLisle via Gcc-patches: > The attached patch was provided by Steve Kargl. After exploring for > possible other checks I settled on leaving the patch intact. > > Two existing test cases updated as different but sensible error messages > resulted. I think this is fine. The error message for CLASS is now arguably more consistent with TYPE. > Regression tested on main line. > > OK to commit? Regarding the format of the commit message: if you want bugzilla to get updated properly, please consider adding PR/fortran ###### to the respective parts below. It is also custom to have a one-line summary including e.g. [PR######] to make it easier for others to relate a commit to bugzilla. OK with these things fixed. Thanks for taking this! Harald > Regards, > > Jerry > > Author: Steve Kargl > Date: Mon Dec 26 14:07:04 2022 -0800 > > Modify checks to avoid referencing NULL pointer. > Update test cases with error messages that changed as a result. > > gcc/fortran/ChangeLog: > > * decl.cc (attr_decl1): Guard against NULL pointer. > * parse.cc (match_deferred_characteristics): Include > BT_CLASS in check for > derived being undefined. > > gcc/testsuite/ChangeLog: > > * gfortran.dg/class_result_4.f90: Update error message che= ck. > * gfortran.dg/pr85779_3.f90: Update error message check.