From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id DBCC03858CDB; Wed, 17 Aug 2022 13:34:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBCC03858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,243,1654588800"; d="scan'208";a="84195926" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 17 Aug 2022 05:34:58 -0800 IronPort-SDR: jH8ghGXYiJJxBM464GxSfk5lfxrF+pIvz69sinwPIgWmR0Vccvchaoo3m9tygAMcUQIXWDDxbt 66vWCeelQ+hTOGX59vxVU55sr3xuOUlmK9JK/zWfvzpj6fj75fzvSlINXGr+uTUFAN8QkoglRA hVDCkTZ0g8l0GCiSsNXd6hHLweInrcIo4OOM8MbAVvIDjTiN0focQpEPKNNAjRTpW3y2KJbK6Y LTXgx+Js4+RnV3bEfZFFfnLy2X5praHFmxhJEbR4G164oY2uNk02V7anzACrtgMWEIaInsLjZb nlo= Message-ID: Date: Wed, 17 Aug 2022 15:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [Patch] Fortran: OpenMP fix declare simd inside modules and absent linear step [PR106566] Content-Language: en-US To: Jakub Jelinek , Tobias Burnus CC: gcc-patches , fortran References: <9dde1b4a-03cb-214c-8eb7-8f75978754c7@codesourcery.com> From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 13:35:02 -0000 On 17.08.22 15:09, Jakub Jelinek wrote: > On Tue, Aug 16, 2022 at 04:45:07PM +0200, Tobias Burnus wrote: >> Fortran: OpenMP fix declare simd inside modules and absent linear step [= PR106566] >> ... > LGTM. > >> +! { dg-final { scan-tree-dump-times "__attribute__\\(\\(omp declare sim= d \\(linear\\(0:ref,step\\(4\\)\\) simdlen\\(8\\)\\)\\)\\)" 2 "gimple" } } ... >> + integer :: p > Wonder if it wouldn't be better to use integer(kind=3D4) explicitly > when you try to match the size of that multiplied by 1 or 2 in > dg-final, as say with -fdefault-integer-8 this will fail miserably > otherwise. Ditto in other spots in this as well as other tests. I assume(d) that no one would compile with -fdefault-integer-8. But possibly it should be changed to permit testing with that flag, given that API routines should be able to handle different default-kind integers. On the other hand, API routines implies 'omp_lib', which is only available in libgomp/testsuite/. > Ok with/without that change. Thanks for the review. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955