From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 16DAF38493D4; Sat, 10 Dec 2022 12:48:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16DAF38493D4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.96,234,1665475200"; d="scan'208";a="89696228" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 10 Dec 2022 04:48:05 -0800 IronPort-SDR: vBmVZtbznOEyof5xjFDY5/ZUitot05APwxDqtdihHPumIfm8eMKdgtXE7xXxW8VZf76NsZ9DPC wozgbHfOWp/rwZZ38VWLtwCw+E3QqyeIUmRnPpduBrGScYgIpqMgENalbZrKOJUZCClmE5nzpT Fnw8TyfSXVzX6hFCAiy1BD+lGUWGvUqvG5agUKiSZrhszZOZB0f5yS+TpgrTON3dpbfg3WUVmZ cMfBHSeSj0Ze6s2CwgCiQhxXtfqkYXSpTu9aIVVOQEvzr+Tyn2kU3fkyZUwZLpZOJ/TeccSJ3e RuQ= Message-ID: Date: Sat, 10 Dec 2022 13:48:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/2] OpenMP: Duplicate checking for map clauses in Fortran (PR107214) Content-Language: en-US To: Julian Brown CC: , Jakub Jelinek , References: <20221020161414.7430-1-julian@codesourcery.com> <20221207190903.78a6b37f@squid.athome> <20221207191355.2e43ea14@squid.athome> <20221210121022.73c2bb32@squid.athome> From: Tobias Burnus In-Reply-To: <20221210121022.73c2bb32@squid.athome> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Julian, On 10.12.22 13:10, Julian Brown wrote: > On Thu, 8 Dec 2022 13:04:20 +0100 > Tobias Burnus wrote: >> All in all, I am fine with the patch - but I spotted some issues. ... > I believe this patch covers all the above cases (hopefully > appropriately generalised), at least for Fortran. I haven't attempted > to fix any missing cases for C, for now. > > Re-tested with offloading to NVPTX (with a few supporting patches, as > before). > > Does this look OK now? Yes, LGTM. Thanks! Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955