From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id CF71D3858D32; Sat, 21 Jan 2023 19:14:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF71D3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1674328463; bh=kvZxTyJPq1kmH7ZTbnlfvmoamkezBbjApNkumlHF0N4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=cFfbpWEQbF4VHSiS8JFZX58rq1oKeqXgkz5nmSMxAqbLohDb9VMf5D45edFNVDYQV OUWLxU6RW4zTGqaEyXuRRJ2aaX3PtMUbWsM7tCPO9LY+6g3VfZoQEpcDckjeaC0hXY cf+p6LpyfoKKO65fpx0iZ9eDNQPcUkbzxpGPQauIoTQGxguhqS62FVF7Idq8tBPNv4 8XZDt3iNqeIw1AnbWDpqvhszbdvktxSFYM8ojCdZRa0zXYpncPFZk8QMzqf8UmxDdy 2kGyXvQHCei6QlYtg5r1FjbFGD242QSUHciaZjBHQwyXFuDqQ+YmwIkIc19KoUBpKI YHekFM969wOtg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.85.20]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mz9Z5-1oXvdE3KuB-00wGpr; Sat, 21 Jan 2023 20:14:23 +0100 Message-ID: Date: Sat, 21 Jan 2023 20:14:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [patch. fortran] PR102595 ICE in var_element, at fortran/decl.c To: Jerry D , gfortran Cc: gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <954b2104-fd92-1e77-5565-7e41b0f8194f@gmail.com> <55839173-e1ca-f047-cef4-b66a911f1577@gmail.com> Content-Language: en-US From: Harald Anlauf In-Reply-To: <55839173-e1ca-f047-cef4-b66a911f1577@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:sSeBdQHJOcQ2oAz6fwhNWXhSkHhUB+TyWW5pQlM20ZPVT7xHELa wqVF/tNybLpP6XQPvrgkF8kCEkt7r9CatDVexEanywjONBc+YNB1YzC8QTRvT4s1Gr8xy58 9Ca6yi2p68Si5lpp6D3z+eB33i7P4ZfM1AwKRJYKW7ymsWkH2tg4kyVMZJ7TqMu0fUSTEie AsWftuuowy18EaEG8MGTA== UI-OutboundReport: notjunk:1;M01:P0:754zby/tCPg=;gFtrI7+dj7jwuewaZxZZB1UyzqL dYwGsTly0KV1GBgrS0NK/55WCuYmRgFi4F8NshVejPX/SqWWXJHCLxJUaOAISZSV8m/uJf6uK kc/jkTX4MGWvORwI8aj70bDTXMuXUk+7iUhYKW6+2l50HE4HiRfSEEtPSkRJ9IjgNwaBmkd++ +gI5aWKr7zn8wIoM4QtjNfgyMpGuA+ys2ltGp9K2djyT1YPKTK57UkY1/4tMc1fnVS2l30Ens erYKfIkXBfnq7VS8iiunr+/yffSMgQw+HmnEfVYArjp9YHCnAxrqvt4SBRL59r1Wk0x9jPqZE 84BRPnf1j6PuhffRaFfrkAJdeyb0taixdhKi4GsTgM49BNrWuGculUa7Dc/AuW3Bv1+8202Nu thJutL1GE0ts4y5cxeiCl7Z7CLz9Eh7iqgSNRl84v72yL/Y84qifNHnLwvvZFxTkCAE4JKoMA 5Y4r+8Fe5ovQcy1BkxtnLmapwuM+WRZSRZm4vKYTnzmZA/Jpyue97+UaL80sgo4IkyVKIwwKM PWG9ygGdz+Wx+papaD39Y8P8UW2FW4DkWloOJudRBn+XQZ1Pc5qY94lRWAZgSfOctOSyH4hIe GphMAbykILmCu0e3ocna150JEN0LPhxzDXknm+2A45FsGqgwjEPRGAyb1fzzEg9ge3t0sxIaU /oHmLkqDrEIYlc6+f3OZUAjejVnyDOaSB8gMzHmyDRsHtUmtDCYPgTcrZeN7/V+B3EYIE6etp 4PSGtEZ/GnfAUUiLf0NcYbN9bLG6W/GlsNnikPilnwqH9eUlHeDsiDthnz+3i34p6D9vIKDzQ 830QoNAa7SWzs6e6DldLwlWl/nRyYdv5VKnkbFu+IuZjMX8ch58NMGoF790k4g2B/LvB/fCcb igLMykfmnp+9CaN50/1rxKP9XBmpWbWpHmpAw+Va+RIF43HB133+tPUqtxl8X9i/4dbtu2fgA a9fehVbXizAfT1PXM7+bhCSM/tg= X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jerry, Am 21.01.23 um 19:27 schrieb Jerry D via Gcc-patches: > On 1/20/23 9:16 PM, Jerry D wrote: >> On 1/20/23 5:46 PM, Jerry D wrote: >>> A PARAMETER value is not allowed in a DATA statement, similar to an >>> EQUIVALENCE. >>> >>> The check for this was in gfc_assign_data_value() in data.cc which >>> turns out to be too late when trying to assign a zero sized array. >> >> Correction, the chunk in data.cc must remain for one test case. I >> spotted this after rerunning check-fortran for several variations. >> > > Attached patch is revised to include a new test case and adjustment of > an existing test case.=C2=A0 It also adds in a return MATCH_ERROR I > accidentally left of the first submit when I was cleaning some things up= . > > Ok for Mainline? the patch looks good to me, so ok for mainline. But please provide a commit message next time. Thanks, Harald > > Jeyy