From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 57AAA3835C03; Fri, 14 Jan 2022 12:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 57AAA3835C03 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: eR9LDNDAPekVuS+5CueEnkA+8m+PxEkdn2fHp9ts9t+G5BJF3g/xUxoBHLIv/qHKz2fiZanHXm vxm6Pj6SYDN74wOOlHaZ3tkfjkvrvXPJLzXsHgyCwUcMAVuxrfwhwlkWvmFNpGo/jxMAvxoNhX cZUsuOSP8vBxUfreLD+SIsa1X1I+DamJyQIVgYqSEFPuDAdb96/Ol2tW6yHWmZmc3Us1T50IEa DIKNQ+MnZtrMVY03awAe5pguPrFhELi6rdcP+46UjR8soU9qcwymPXkjDcRahVTLFcflkW9V9o bL2Cnf7TnE3zHQNXgGwWnYj1 X-IronPort-AV: E=Sophos;i="5.88,288,1635235200"; d="scan'208";a="70635655" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 14 Jan 2022 04:20:49 -0800 IronPort-SDR: AWl7uC9i9DcOzBWNXLg5lI5xLu0t2IN8PtdMBnYiSUKJ/zNdOzKM48RcL6UixAMFCBXAFUKAwJ pCxp4gxMEBxRcA5tRGYWlHYQcxigMgAOrV9xFtkf39aNXYkfsYp75QEKZi6QzDPTbQlPN/6qVP Kn1WCj9sl/mWxDz3TujRjbiGK3fgjKsLQ+aq3Q/wUtfN8NPzSk6o2O5xTJQcr766R6nqSqyj4c hDzwyC0MR6LwaBad9Lw6z9AVrIZspfyacM8/JUPDqJjF7DIREhrWCeDZtvG5BUHY56KCczdlhR GNc= Message-ID: Date: Fri, 14 Jan 2022 13:20:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0). Content-Language: en-US To: Jakub Jelinek , Hafiz Abid Qadeer CC: , Thomas Schwinge , References: <20211022130502.2211568-1-abidh@codesourcery.com> <20211102162714.GF304296@tucnak> <20211220200650.GN2646553@tucnak> <87bl0evg25.fsf@euler.schwinge.homeip.net> <20220114115557.GK2646553@tucnak> From: Tobias Burnus In-Reply-To: <20220114115557.GK2646553@tucnak> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 12:20:50 -0000 On 14.01.22 12:55, Jakub Jelinek via Fortran wrote: > If we want to check intptr_t, we should guard the dg-error with > "" { target { lp64 || llp64 } } > or so. Well, if we want to use intptr_t, we could use be explicitly as with: use iso_c_binding, only: c_intptr_t ! use omp_lib, only: omp_allocator_handle_kind ... ('implicit none' etc.) integer, parameter :: omp_allocator_handle_kind =3D c_intptr_t ... integer(kind=3Domp_allocator_handle_kind) (@Abid: The 'use omp_lib' line is commented as in gcc/testsuite/*/gomp/, the OpenMP module/header from libgomp is not available - and then a stub parameter is created.) > Otherwise yes, we can add some other kind and hope it is not the > same as omp_allocator_handle_kind. Or we can do both, > keep the current one with the target lp64 || llp64 and > add another one with some integer(kind=3D1). For just testing something invalid, I think it makes more sense to just set it to kind=3D1. For checking the valid value, using c_intptr_t seems to make more sense than restricting it to (l)l64. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955