From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27273 invoked by alias); 17 Aug 2016 16:44:52 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 23035 invoked by uid 89); 17 Aug 2016 16:44:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=greenhalgh, Greenhalgh, TEST_I_F_VAL, UD:fp-int-convert.h X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Aug 2016 16:44:40 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ba3xE-0000CY-NA from joseph_myers@mentor.com ; Wed, 17 Aug 2016 09:44:36 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Wed, 17 Aug 2016 17:44:35 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.86_2) (envelope-from ) id 1ba3xB-0003ZX-T3; Wed, 17 Aug 2016 16:44:33 +0000 Date: Wed, 17 Aug 2016 16:44:00 -0000 From: Joseph Myers To: James Greenhalgh CC: , , , , , , , , , , , Subject: Re: Implement C _FloatN, _FloatNx types [version 5] In-Reply-To: <20160817154244.GA39270@arm.com> Message-ID: References: <20160817154244.GA39270@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-08/txt/msg00080.txt.bz2 On Wed, 17 Aug 2016, James Greenhalgh wrote: > The obvious fix would be this modification to fp-int-convert.h: > > - TEST_I_F_VAL (U, F, (U)~(((U)~(U)0) >> 1), 1); \ > + TEST_I_F_VAL (U, F, (U)~(((U)~(U)0) >> 1), P_OK1 (P, U)); \ That's not logically correct, because this is an issue about exponent range, not precision; it's fine to test this input value when converting from TImode to float, for example, because it's 2**127 which is exactly representable in float. I'll do another revision of the patch that addresses this and has other testsuite improvements (but no changes to the actual compiler changes, which still need review for language-independent changes outside the rs6000 back end). -- Joseph S. Myers joseph@codesourcery.com