From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23217 invoked by alias); 11 Apr 2018 19:47:32 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 23146 invoked by uid 89); 11 Apr 2018 19:47:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=limits X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout3.netcologne.de Received: from cc-smtpout3.netcologne.de (HELO cc-smtpout3.netcologne.de) (89.1.8.213) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Apr 2018 19:47:29 +0000 Received: from cc-smtpin1.netcologne.de (cc-smtpin1.netcologne.de [89.1.8.201]) by cc-smtpout3.netcologne.de (Postfix) with ESMTP id 3326012A62; Wed, 11 Apr 2018 21:47:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin1.netcologne.de (Postfix) with ESMTP id 306BC11D99; Wed, 11 Apr 2018 21:47:27 +0200 (CEST) Received: from [78.35.153.70] (helo=cc-smtpin1.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 5ace664f-029d-7f0000012729-7f000001e181-1 for ; Wed, 11 Apr 2018 21:47:27 +0200 Received: from [192.168.178.68] (xdsl-78-35-153-70.netcologne.de [78.35.153.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin1.netcologne.de (Postfix) with ESMTPSA; Wed, 11 Apr 2018 21:47:23 +0200 (CEST) Subject: Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT To: Jakub Jelinek Cc: sgk@troutmask.apl.washington.edu, "fortran@gcc.gnu.org" , gcc-patches References: <20180409202803.GB51810@troutmask.apl.washington.edu> <20180410133602.GF8577@tucnak> <3e6497e3-56b8-91ea-5a19-c41e6d28a073@netcologne.de> <20180411154423.GU8577@tucnak> <8d3541f6-ecc5-66d1-d59c-d5b5c4b8f8a6@netcologne.de> <20180411183333.GY8577@tucnak> From: Thomas Koenig Message-ID: Date: Wed, 11 Apr 2018 19:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180411183333.GY8577@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00054.txt.bz2 Am 11.04.2018 um 20:33 schrieb Jakub Jelinek: >> I have attached updated patch which moves the test case to >> gfortran.dg/gomp (where it actually passes). > > How could it pass there? dg-do run tests don't belong into g*.dg/gomp/, > nothing adds the -B etc. options needed to find libgomp.spec or libgomp > as a library, or adds it to LD_LIBRARY_PATH etc. > There are zero dg-do run tests in gfortran.dg/gomp/, there are 4 > dg-do run tests in c-c++-common/gomp/, but those work fine because they > use -fopenmp-simd option rather than > -fopenmp/-fopenacc/-ftree-parallelize-loops= etc. So, where should the test go? The suggestion in PR 85346, to put it into libgomp/testsuite/libgomp.fortran/, does not work: Running ../../../../trunk/libgomp/testsuite/libgomp.fortran/fortran.exp ... FAIL: libgomp.fortran/do_concurrent_5.f90 -O execution test even when ne (the array size) has been reduced to 2**20, far below reasonable memory limits. The test passes when given the -O1 -ftree-parallelize-loops=2 options by hand. So, what's the idea? Is there actually a directory which works, or are we left with a wrong-code bug for which no test case is possible? That would be quite bad, I think. Thomas