From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id B26053858029; Tue, 11 Jan 2022 22:11:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B26053858029 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([79.251.13.44]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MOiDd-1mhwAW1rR9-00QFrJ; Tue, 11 Jan 2022 23:11:47 +0100 Message-ID: Date: Tue, 11 Jan 2022 23:11:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs Content-Language: en-US To: FX Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: <2F9F946D-C06C-4D3A-AD24-33913F040B3B@gmail.com> From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wmRLmYxqDXIZ4WuTDd2lPPfP8gtITr1jHJJvCQQp6/tZ2ZakcN3 bTdmLHQA8pThyytr8a2vzHjJQwbg1mvgXQqT+vmgqRdIcm1zECIdge44CQkErlNpmxPpsP8 fXGIC/lbI096NgWW6gvjSQXsXXQaddYPTUK+l/n6sfStp5kyzoaFPqUVHZeloHDg5tCw69h w9D1VacknjHGfY5wLkAjg== X-UI-Out-Filterresults: notjunk:1;V03:K0:fl61wwUam90=:hS1l8lW6kfmjU1ZCfanW/P 8RNP5r38NoGhRltIkNftGQXYeKSY5PXUrHZwDj4xRsP1vq5Cb00zKo9osMBQUeIKkGi+RipWI 6y5Tcy43TKIUwF3iCkLDRvqg0hX1Z1uDaah1+K75FqsNitDCmYU1j0JhnkVlRwJ+a63LswO9G 5P0BN0FJWFlrmzbtvrizCdh+WsEn2/W+40PBlZ+S8dhni5+9RUeju0bQjd1/apJgUVXQzuWur riGe4Z0enpRZ583Dv/Yp6mHlEWGTR8G1CqsFrld4+5iCSgrAHqYl8EgpCX/6godDUFIwLhZpc tlKxyLGE2HhPcjYS9If6+1WaCh9nL9A4nv/PkJE+AHi4r43l0n5fj33vREKmuGvV2FqoqqpcW 4iGHGVf9ZBYyHAOlRJf23Qqp5MUFOWFteavzBoRiEJQa5ZifV72fJD0q8hacmIN0iJkiBFm7k rhak4VEUOThor61VhpNN4ERHLkfuHhELicqSX17mhhZaAg85D8zuIE42mYILuEcjc3BCh/PMm gEdeEYaWp1P1Fvvb47QY1GnsqnTq5T8eSYvTfxpp0fcTkOeoVERUWwYdvXbe9XQgL6zeO8MHg K2Y4528oqwZGRQjDY/Rsw1JOD5EazZDvtfSfD48rLZ5syfyUs6nY/9GXloTSLlePyfNcyTH5u hrSEOTIJU7XNoMs1HfD0qUUZKNaHLgjoRrggkw4U7oqQO7N6pgnhw8IaUL0pnq9Asl12P36Kk G6zmt97Lusva1p+NKlWALORC0dumKtMQSoBDH+hAGXOYqsLq8nepOONDBxzzxlxIlKxEqd9Ok 5divKJcjgspHLa5t1Q2OEAHqF/5pHdP4GkrCUwsJlcaIQyv5bhMm7/+0PFtYdTNARjgjWaBkm roXWEFxHT8dR/PgUfJae2bMvT9yR/jfkGMMwvOaNdo+m6HTgGKIE5J9NDaoQNsObdvZWuRDe1 wIL+TGDAu657y55fL7AxXK2YqpD0nioKS3cWJ5YQqbGacTGHkkDwSqH34+lYYfl5UMsVxkv/m yCWMtW2i1bqrSaSWWey5/xCEbMJoIKCTX98nmkGjgxDCkB17ZJGvYtrQZUB7Qwwru/mp71wTH UeVbLag1FkEvgk= X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 22:11:51 -0000 Hi FX, Am 11.01.22 um 23:04 schrieb FX via Fortran: > Hi Harald, > >> I think this patch breaks the testsuite > > On what platform? It regtested fine on x86_64-pc-linux-gnu I looked at gcc-testresults and find e.g. https://gcc.gnu.org/pipermail/gcc-testresults/2022-January/747938.html https://gcc.gnu.org/pipermail/gcc-testresults/2022-January/747935.html which is x86 (64 and 32 bit) by H.J.; plus some more. Maybe H.J. can explain what is different from your platform? > >> since the directive >> ! { dg-additional-sources signaling_1_c.c } >> should rather read >> ! { dg-additional-sources "signaling_1_c.c" } > > I find plenty of evidence saying it=E2=80=99s allowed (just quoting a fe= w, but there are a lot): > > ./gfortran.dg/PR94331.f90:! { dg-additional-sources PR94331.c } > ./gfortran.dg/global_vars_c_init.f90:! { dg-additional-sources global_va= rs_c_init_driver.c } > ./gfortran.dg/c_char_tests.f03:! { dg-additional-sources c_char_driver.c= } > > > FX Harald From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 7C4E3393A415 for ; Tue, 11 Jan 2022 22:11:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C4E3393A415 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n7PMv-0003zn-GH for fortran@gcc.gnu.org; Tue, 11 Jan 2022 23:11:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs Date: Tue, 11 Jan 2022 23:11:46 +0100 Message-ID: References: <2F9F946D-C06C-4D3A-AD24-33913F040B3B@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Content-Language: en-US In-Reply-To: Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 22:11:58 -0000 Message-ID: <20220111221146.hLU-xBNr9CsQIlqCUbFgdoTXb0QX59bLYSDEzRxjNFo@z> Hi FX, Am 11.01.22 um 23:04 schrieb FX via Fortran: > Hi Harald, > >> I think this patch breaks the testsuite > > On what platform? It regtested fine on x86_64-pc-linux-gnu I looked at gcc-testresults and find e.g. https://gcc.gnu.org/pipermail/gcc-testresults/2022-January/747938.html https://gcc.gnu.org/pipermail/gcc-testresults/2022-January/747935.html which is x86 (64 and 32 bit) by H.J.; plus some more. Maybe H.J. can explain what is different from your platform? > >> since the directive >> ! { dg-additional-sources signaling_1_c.c } >> should rather read >> ! { dg-additional-sources "signaling_1_c.c" } > > I find plenty of evidence saying it’s allowed (just quoting a few, but there are a lot): > > ./gfortran.dg/PR94331.f90:! { dg-additional-sources PR94331.c } > ./gfortran.dg/global_vars_c_init.f90:! { dg-additional-sources global_vars_c_init_driver.c } > ./gfortran.dg/c_char_tests.f03:! { dg-additional-sources c_char_driver.c } > > > FX Harald