From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tkoenig@netcologne.de>
Received: from cc-smtpout1.netcologne.de (cc-smtpout1.netcologne.de
 [IPv6:2001:4dd0:100:1062:25:2:0:1])
 by sourceware.org (Postfix) with ESMTPS id 576483858027;
 Tue, 22 Feb 2022 19:08:20 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 576483858027
Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202])
 by cc-smtpout1.netcologne.de (Postfix) with ESMTP id B2439125E0;
 Tue, 22 Feb 2022 20:08:18 +0100 (CET)
Received: from [IPV6:2001:4dd6:622:0:7285:c2ff:fe6c:992d]
 (2001-4dd6-622-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de
 [IPv6:2001:4dd6:622:0:7285:c2ff:fe6c:992d])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA id 564F111DCD;
 Tue, 22 Feb 2022 20:08:16 +0100 (CET)
Message-ID: <b88616f2-95e0-45d4-09d6-ac4933efdac3@netcologne.de>
Date: Tue, 22 Feb 2022 20:08:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] PR fortran/104619 - [10/11/12 Regression] ICE on list
 comprehension with default derived type constructor
Content-Language: en-US
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
 gcc-patches <gcc-patches@gcc.gnu.org>
References: <trinity-09b868ea-e496-4eaf-9306-adf4a8a68278-1645480551337@3c-app-gmx-bs09>
From: Thomas Koenig <tkoenig@netcologne.de>
In-Reply-To: <trinity-09b868ea-e496-4eaf-9306-adf4a8a68278-1645480551337@3c-app-gmx-bs09>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-NetCologne-Spam: L
X-Rspamd-Queue-Id: 564F111DCD
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: fortran@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Fortran mailing list <fortran.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/fortran/>
List-Help: <mailto:fortran-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Feb 2022 19:08:23 -0000

Hi Harald,

> a recently introduced shape validation for an array constructor
> against the declared shape of a DT component failed to punt if
> the shape of the constructor cannot be determined at compile time.
> 
> Suggested solution: skip the shape check in those cases.
> 
> Regtested on x86_64-pc-linux-gnu.  OK for mainline / affected branches?

Looks good to me.

Thanks for the patch!

Best regards

	Thomas