public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch] Fortran: F2018 type(*),dimension(*) with scalars [PR104143]
Date: Tue, 20 Sep 2022 21:59:22 +0200	[thread overview]
Message-ID: <b9167e35-57c1-26ec-9152-487a6d5144c8@gmx.de> (raw)
In-Reply-To: <86200df9-4b14-11ca-05db-1d033870f537@codesourcery.com>

Am 20.09.22 um 13:51 schrieb Tobias Burnus:
> In several cases, one just wants to have the address where an object starts
> without requiring the detour via 'c_loc' and the (locally) required 
> 'target'
> attribute.
> 
> In principle,  type(*),dimension(*)  of TS29113 permits this, except that
> 'dimension(*)' only permits arrays and array elements but not scalars.
> 
> Fortran 2018 modified this such that with 'type(*)' also scalars are 
> permitted.
> (See PR for the quotes.)
> 
> This patch implements this simple change. Before, implementations like MPI
> had to use '!GCC$ attribute NO_ARG_CHECK ::' in addition to 
> type(*),dimension(*)
> to achieve this. In GCC, we do likewise, but that's at least inside the 
> compiler,
> cf. libgomp/openacc{.f90,_lib.h}.
> 
> OK for mainline?

LGTM.

Thanks for the patch!




WARNING: multiple messages have this Message-ID
From: Harald Anlauf <anlauf@gmx.de>
To: Tobias Burnus <tobias@codesourcery.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: F2018 type(*),dimension(*) with scalars [PR104143]
Date: Tue, 20 Sep 2022 21:59:22 +0200	[thread overview]
Message-ID: <b9167e35-57c1-26ec-9152-487a6d5144c8@gmx.de> (raw)
Message-ID: <20220920195922.h5B5pdmtit8vAo8bltwnEsm7tQcY6u5thzZO_HkOcVY@z> (raw)
In-Reply-To: <86200df9-4b14-11ca-05db-1d033870f537@codesourcery.com>

Am 20.09.22 um 13:51 schrieb Tobias Burnus:
> In several cases, one just wants to have the address where an object starts
> without requiring the detour via 'c_loc' and the (locally) required
> 'target'
> attribute.
>
> In principle,  type(*),dimension(*)  of TS29113 permits this, except that
> 'dimension(*)' only permits arrays and array elements but not scalars.
>
> Fortran 2018 modified this such that with 'type(*)' also scalars are
> permitted.
> (See PR for the quotes.)
>
> This patch implements this simple change. Before, implementations like MPI
> had to use '!GCC$ attribute NO_ARG_CHECK ::' in addition to
> type(*),dimension(*)
> to achieve this. In GCC, we do likewise, but that's at least inside the
> compiler,
> cf. libgomp/openacc{.f90,_lib.h}.
>
> OK for mainline?

LGTM.

Thanks for the patch!


  reply	other threads:[~2022-09-20 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 11:51 Tobias Burnus
2022-09-20 19:59 ` Harald Anlauf [this message]
2022-09-20 19:59   ` Harald Anlauf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9167e35-57c1-26ec-9152-487a6d5144c8@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).