From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 287F13858C36; Tue, 9 May 2023 18:29:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 287F13858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1683656971; i=anlauf@gmx.de; bh=OoG8xgDK3LMvdiP04M7k4XaZmUXloGvGMb5GK9tlIcI=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=O2A3Eqwj3tqODO2y4jB3s2wUL357T3xt9yuz7a8BfIogK7TNJ1s9UxCLcJbW5JB3x dgPJ3ydJFcwMPaW/ztVHaQAkkzQ7SmICjm3uB0CE00hQHKzi2ueY1NDx5qWDTK7xek MahAG8PoCa414wFH9fE9QHrM6YTx9BprKjyD2UKdhzowqoQBiWYjF+/WiMEsXTDrCM jIRtfKl3ljA3AezHdhuDNLvzFqj07mcgBMI9d7YGvM+V/6P/MThkwGJMu4yxqfvoLp K2YWyOnKhBAVDXOGZtFZlbaVBb1LGXsCQlcVJnwnNCVayAbN79hYpA3g2cKA3dIsms HCH1K9GiMtEiw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.91.40]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1ML9uK-1peNGz1Rn0-00I9HX; Tue, 09 May 2023 20:29:31 +0200 Message-ID: Date: Tue, 9 May 2023 20:29:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [Patch, fortran] PR103716 - [10/11/12/13/14 Regression] ICE in gimplify_expr, at gimplify.c:15964 Content-Language: en-US To: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SJnv1IJ0oTDA087X57p9fRtcEZHQ2gGsjNAU33JjrBO6qZoeS4M cM9doyIppG/195bAgYgQ9ntvYILbnjmkSDs7APkb8iTbcTP/ls/XJcHlflSlB/zj6A6hFIL ezokn9sX1o4EWmx/NpvkV26T6aWVAwUo/5gvoEjtJdGFKm4XjUIUW3NzCz7PX/js8f66DuF GldQAjVovgYzfJBte7ifA== UI-OutboundReport: notjunk:1;M01:P0:Otcy9r9n7bU=;NI9VDJFDELP9SzKXETIpj75yFm8 Md45/UsPxOFA0Y4M6bROJXyc6TPJlAYxwueg9rD5euVF9SGdknAALex63KZRE2DabiyzVC/6N QaergTslzxuDzqmckcoyc77D4qJ/H5kJuN9iBjyF+OqD26UEceeSGFZyxpjvi0ftZeGokZALI dj9smugiW9OohI7Jrg27Z75pBggON4j1EM8T818f2XHHhGlMJvVSloeyzb7FaWbXdKezMIrBD WnpnVjx4QATmxbMbBw2DpOMXnkquEbVyVf5NtH8jEsdhRMKToiMxv+pRgqqH5cxxznbx4KDEI HQfwgoQH83hDAi+6PBEzTKDFFcr86GafKXk/8ZNT8d7FPBcGa1eLExRSiFQfAeZwoI0jO8wS6 mgaD94XaLp5jQ9LeBMcYvsYzBh+a79+lySBY4cPAE+yIRMU4cJzjtzSqu+2j2Z2Ofgrgo9cFG y0H0FXCprpMNcEdHjJGnFSzNI6Q9xwsW1ZebiXIitaha6LWfE/84/KGy9MYv7aF3v0/K6lg8P kO7/uLy4Xi7JrwHzLLU+rvGlQvNnR2N6Ye/ej5cK63hwwBp4Xa5HKzC6fIVtvfbz2S+aZd2em 7fkqZtWphvVRDuP0h0q97B/7UaBJl2ru1lW/L4czrJzo6RskPQ32XZ2Snk6mpjpwfyx4E+s9F Gd59U2X422DXLz9+IHWTKCJlnWmynEcF9EC50VV96auNqkSbzWRPxI0GOz5ZktBO7b7sw3PAX DB/s2xgY0lxsyLcgWWG2+LoxyjOIi24dtSzwdRPqSuOLojlClj+HuW2EBXfWbCZ7osCN63rtb 15SuCZZTUMxrgXdIKUYD2rCiyYgqDfXhSP8JicPAc8p5LTNus8k0fcj+xVe7u/LAJquil3NSO MFT0MQZ5CPDMwg+gSXptQIQOotJKw4t24uO/SFomj/SoFs8QdKisK0RknNbJkKx8fBQVJukqG FdTPtQSvAnEgAD+KG+lN+mz4cBE= X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, On 5/9/23 18:00, Paul Richard Thomas via Gcc-patches wrote: > Hi All, > > This problem caused the gimplifier failure because the reference chain > ending in an inquiry_len still retained a full array reference. This had > already been corrected for deferred character lengths but the fix extend= s > this to all characters without a length expression and integer expressio= ns, > which is the correct type of course, that retain a full array_spec. The > nullification of the se->string length in conv_inquiry is a > belts-and-braces measure to stop it from winding up as a hidden argument= in > procedure calls. > > OK for trunk and, after a decent delay, backporting? ENOTESTCASE. Nevertheless the patch LGTM and is also OK for backporting. Thanks for fixing this! Harald > Cheers > > Paul > > Fortran: Fix assumed length chars and len inquiry [PR103716] > > 2023-05-09 Paul Thomas > > gcc/fortran > PR fortran/103716 > * resolve.cc (gfc_resolve_ref): Conversion of array_ref into an > element should be done for all characters without a len expr, > not just deferred lens, and for integer expressions. > * trans-expr.cc (conv_inquiry): For len and kind inquiry refs, > set the se string_length to NULL_TREE. > > gcc/testsuite/ > PR fortran/103716 > * gfortran.dg/pr103716 : New test.