From: Tobias Burnus <tobias@codesourcery.com>
To: "José Rui Faustino de Sousa" <jrfsousa@gmail.com>,
fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [Patch, fortran V3] PR fortran/100683 - Array initialization refuses valid
Date: Mon, 21 Jun 2021 14:37:43 +0200 [thread overview]
Message-ID: <bdb2355b-eb8e-1def-f998-c23e9dacf654@codesourcery.com> (raw)
In-Reply-To: <aa24b662-f174-b520-8b54-e5d26e7bd218@gmail.com>
Hi José,
On 17.06.21 21:34, José Rui Faustino de Sousa via Gcc-patches wrote:
> Update to a proposed patch to:
> PR100683 - Array initialization refuses valid
> due to more errors being found...
>
> Patch tested only on x86_64-pc-linux-gnu.
LGTM – sorry for the very belated review.
> Add call to simplify expression before parsing
Nit: I think you mean resolving/processing/expanding/checking – as
gfc_resolve_expr comes after the actual parsing.
> *and* check *appropriately* if the expression is still an array after
> simplification.
* * *
I have to admit that I got a bit lost with your patches. Are there still
outstanding patches? I also recall approving a patch quite some time ago
which was then not committed for a long time. (I have not checked
whether it was committed by now.)
Thus: Do you have a list of patches pending review? Secondly, I assume
you can commit or do you have commit issues?
Tobias
> Fortran: Fix bogus error
>
> gcc/fortran/ChangeLog:
>
> PR fortran/100683
> * resolve.c (gfc_resolve_expr): Add call to gfc_simplify_expr.
>
> gcc/testsuite/ChangeLog:
>
> PR fortran/100683
> * gfortran.dg/pr87993.f90: increased test coverage.
> * gfortran.dg/PR100683.f90: New test.
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
next prev parent reply other threads:[~2021-06-21 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:34 José Rui Faustino de Sousa
2021-06-21 12:37 ` Tobias Burnus [this message]
2021-06-21 15:21 ` José Rui Faustino de Sousa
2021-06-21 18:27 ` Paul Richard Thomas
2021-10-22 7:42 ` José's pending bind(C) patches / status (was: Re: [Patch, fortran V3] PR fortran/100683 - Array initialization refuses valid) Tobias Burnus
2021-10-22 8:19 ` Paul Richard Thomas
2021-10-22 13:06 ` Tobias Burnus
2021-10-22 20:29 ` Harald Anlauf
2021-10-22 20:36 ` Harald Anlauf
2021-10-22 20:44 ` Harald Anlauf
-- strict thread matches above, loose matches on Subject: below --
2021-06-03 15:04 [Patch, fortran] PR fortran/100120/100816/100818/100819/100821 problems raised by aggregate data types dhumieres.dominique
2021-06-04 15:24 ` Paul Richard Thomas
2021-06-05 12:40 ` dhumieres.dominique
2021-06-06 17:58 ` Re:[Patch, fortran] PR fortran/93308/93963/94327/94331/97046 problems raised by descriptor handling dhumieres.dominique
2021-06-19 10:57 ` [Patch, fortran v2] " dhumieres.dominique
2021-06-19 11:00 ` [Patch, fortran V3] PR fortran/100683 - Array initialization refuses valid dhumieres.dominique
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdb2355b-eb8e-1def-f998-c23e9dacf654@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jrfsousa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).