From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id DE9583858C42; Mon, 20 Nov 2023 14:49:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE9583858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE9583858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700491742; cv=none; b=ksPbCdiWJYpXlDeabkFiTAYa/PdSFux6fSk8P4hl6h3Ef5e/TYzAB10tE1pHUhFZwowacPn5XlpjBMpXtgCwwOhpdZYe/XpE1jiLvnCA52nCFki2W5f9PSENjfe9mO6MwmAmjbRhTqEwLLY22QfVceNKKQ0dTvENBbTvl5vUY/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700491742; c=relaxed/simple; bh=x0/iDh4qWfV1aKn66zv1cDP/MCUSiwFOs2/Br7OadCg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=qK/ywiGNSgyQV3VAXIs4WnUVwQ+7zruxUop5Gs3Q1GpfIsVKSaL6K6qQDK6LrdEEWhgBcK9zqysEw3v4G6mztY4p8J7Zl+uluxKVhmzWmw3ZTLsBqYGnZvQmTD0gQkIyPI+UfUXn6Lj1/0nkeAE5cTly6QtviskHoD09kAz/fG4= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: JUN/tORURwSgLvjt9iU8gg== X-CSE-MsgGUID: +fDivQIgQM67CjbIvz5luQ== X-IronPort-AV: E=Sophos;i="6.04,214,1695715200"; d="f90'?scan'208";a="23263803" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 20 Nov 2023 06:48:57 -0800 IronPort-SDR: kmC6JjXf56PQckbQ3m7NINN+DhSrHLPAySPyJtu/MMGaXloidoVD5BXfTLsjAYEQ865/uTpUvU DfrmxeJ0lnvqFix8Q17kP2uTYnjSuCRczkIKOBG5hO0qKqqpVdygabVcob4Xd1/Iebw46Sgbdx Jun5UQ/REqIlGV5aZg44MD+URWmMigbjOC9v3bEsjf5Hnp/5Ye0lDHg8GG66Q9gMXAodJ2iUvj McE7Wenk13YC4jGJrawy85gfhy/eynsV2sx0YEkzp4EMz0lA9cEKzMf3y9w3mo/Zi50UiFBKsh +3M= Content-Type: multipart/mixed; boundary="------------jZkim699WKTV5MBcugHQNrju" Message-ID: Date: Mon, 20 Nov 2023 15:48:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fortran: fix reallocation on assignment of polymorphic variables [PR110415] Content-Language: en-US To: Andrew Jenner , , gcc-patches References: <8365320d-ce39-4182-9c58-411436318437@codesourcery.com> From: Tobias Burnus In-Reply-To: <8365320d-ce39-4182-9c58-411436318437@codesourcery.com> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_LOTSOFHASH,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------jZkim699WKTV5MBcugHQNrju Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hi Andrew, On 20.11.23 14:56, Andrew Jenner wrote: > This patch adds the testcase from PR110415 and fixes the bug. Thanks. I can confirm experimentally that it fixes the original PR. Howeve= r, if I extend the original testcase (-2), it fails with run with valgrind or when run wit= h -fsanitize=3Daddress. The array testcase (-3) seems to be fine with and without your patch. I think it makes sense to include both extended testcases and put them unde= r gcc/testsuite/gfortran.dg/asan/ to ensure ASAN checks for leaks and some in= valid memory access. I still should have a closer look at the -ftree-dump-original and at the pa= tch itself. * * * For the '-2' testcase, ASAN (-fsanitize=3Dundefined) shows: =3D=3D11823=3D=3DERROR: AddressSanitizer: heap-use-after-free on address 0x= 608000000220 at pc 0x000000405d39 bp 0x7ffcfa6eef50 sp 0x7ffcfa6eef48 WRITE of size 96 at 0x608000000220 thread T0 #0 0x405d38 in __copy_MAIN___D gcc/testsuite/gfortran.dg/pr110415.f90:= 5 #1 0x404dc0 in MAIN__ gcc/testsuite/gfortran.dg/pr110415.f90:24 #2 0x40a82b in main gcc/testsuite/gfortran.dg/pr110415.f90:28 #3 0x7f1e2a4281af in __libc_start_call_main (/lib64/libc.so.6+0x281af)= (BuildId: bbeee08e5f56966e641c4f3ba4ea1da9d730d0ab) #4 0x7f1e2a428278 in __libc_start_main@@GLIBC_2.34 (/lib64/libc.so.6+0= x28278) (BuildId: bbeee08e5f56966e641c4f3ba4ea1da9d730d0ab) #5 0x402274 in _start ../sysdeps/x86_64/start.S:115 0x608000000220 is located 0 bytes inside of 96-byte region [0x608000000220,= 0x608000000280) freed by thread T0 here: #0 0x7f1e2b4daf35 (/lib64/libasan.so.8+0xdaf35) (BuildId: 3e1694ad218= c99a8b1b69231666a27df63cf19d0) #1 0x404d1c in MAIN__ gcc/testsuite/gfortran.dg/pr110415.f90:24 #2 0x40a82b in main gcc/testsuite/gfortran.dg/pr110415.f90:28 #3 0x7f1e2a4281af in __libc_start_call_main (/lib64/libc.so.6+0x281af)= (BuildId: bbeee08e5f56966e641c4f3ba4ea1da9d730d0ab) previously allocated by thread T0 here: #0 0x7f1e2b4dc03f in malloc (/lib64/libasan.so.8+0xdc03f) (BuildId: 3e= 1694ad218c99a8b1b69231666a27df63cf19d0) #1 0x4042d2 in MAIN__ gcc/testsuite/gfortran.dg/pr110415.f90:22 #2 0x40a82b in main gcc/testsuite/gfortran.dg/pr110415.f90:28 #3 0x7f1e2a4281af in __libc_start_call_main (/lib64/libc.so.6+0x281af)= (BuildId: bbeee08e5f56966e641c4f3ba4ea1da9d730d0ab) * * * Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------jZkim699WKTV5MBcugHQNrju Content-Type: text/x-fortran; charset="UTF-8"; name="pr110415-2.f90" Content-Disposition: attachment; filename="pr110415-2.f90" Content-Transfer-Encoding: base64 ISB7IGRnLWRvIHJ1biB9CiEKISBDb250cmlidXRlZCBieSBCcmFkIFJpY2hhcmRzb24gPGV2 ZXJ5dGhpbmdmdW5jdGlvbmFsQHByb3Rvbm1haWwuY29tPgohCmltcGxpY2l0IG5vbmUKICB0 eXBlLCBhYnN0cmFjdCA6OiBwCiAgICBpbnRlZ2VyIDo6IGEgPSA0CiAgZW5kIHR5cGUgcAoK ICB0eXBlLCBleHRlbmRzKHApIDo6IGMKICAgIGludGVnZXIgOjogYiA9IDcKICAgIGNoYXJh Y3RlcihsZW49OiksIGFsbG9jYXRhYmxlIDo6IHN0ciwgc3RyMig6KQogIGVuZCB0eXBlIGMK CiAgdHlwZSwgZXh0ZW5kcyhwKSA6OiBkCiAgICBpbnRlZ2VyIDo6IGVmID0gNwogICAgY2hh cmFjdGVyKGxlbj06KSwgYWxsb2NhdGFibGUgOjogc3RyLCBzdHIyKDopCiAgZW5kIHR5cGUg ZAoKICBjbGFzcyhwKSwgYWxsb2NhdGFibGUgOjogYQoKICBhID0gZnVuYygpCgogIGEgPSBm dW5jMigpCgogIGEgPSBmdW5jKCkKCiAgZGVhbGxvY2F0ZShhKQoKY29udGFpbnMKICBmdW5j dGlvbiBmdW5jMigpIHJlc3VsdChhKQogICAgY2xhc3MocCksIGFsbG9jYXRhYmxlIDo6IGEK ICAgIGEgPSBkKCkKICBlbmQgZnVuY3Rpb24gZnVuYzIKCiAgZnVuY3Rpb24gZnVuYygpIHJl c3VsdChhKQogICAgY2xhc3MocCksIGFsbG9jYXRhYmxlIDo6IGEKCiAgICBhID0gYygpCiAg ICBzZWxlY3QgdHlwZShhKQogICAgdHlwZSBpcyAoYykKICAgICAgYSVzdHIgPSAnYWJjZCcK ICAgICAgYSVzdHIyID0gWydhYmNkJywnZWZnaCddCiAgICBlbmQgc2VsZWN0CiAgZW5kIGZ1 bmN0aW9uIGZ1bmMKZW5kIHByb2dyYW0K --------------jZkim699WKTV5MBcugHQNrju Content-Type: text/x-fortran; charset="UTF-8"; name="pr110415-3.f90" Content-Disposition: attachment; filename="pr110415-3.f90" Content-Transfer-Encoding: base64 ISB7IGRnLWRvIHJ1biB9CiEKISBDb250cmlidXRlZCBieSBCcmFkIFJpY2hhcmRzb24gPGV2 ZXJ5dGhpbmdmdW5jdGlvbmFsQHByb3Rvbm1haWwuY29tPgohCmltcGxpY2l0IG5vbmUKICB0 eXBlLCBhYnN0cmFjdCA6OiBwCiAgICBpbnRlZ2VyIDo6IGEgPSA0CiAgZW5kIHR5cGUgcAoK ICB0eXBlLCBleHRlbmRzKHApIDo6IGMKICAgIGludGVnZXIgOjogYiA9IDcKICAgIGNoYXJh Y3RlcihsZW49OiksIGFsbG9jYXRhYmxlIDo6IHN0ciwgc3RyMig6KQogIGVuZCB0eXBlIGMK CiAgdHlwZSwgZXh0ZW5kcyhwKSA6OiBkCiAgICBpbnRlZ2VyIDo6IGVmID0gNwogICAgY2hh cmFjdGVyKGxlbj06KSwgYWxsb2NhdGFibGUgOjogc3RyLCBzdHIyKDopCiAgZW5kIHR5cGUg ZAoKICBjbGFzcyhwKSwgYWxsb2NhdGFibGUgOjogYSg6KQoKICBhID0gZnVuYygpCgogIGEg PSBmdW5jMigpCgogIGEgPSBmdW5jKCkKCiAgZGVhbGxvY2F0ZShhKQoKY29udGFpbnMKICBm dW5jdGlvbiBmdW5jMigpIHJlc3VsdChhKQogICAgY2xhc3MocCksIGFsbG9jYXRhYmxlIDo6 IGEoOikKICAgIGEgPSBbZCgpLGQoKV0KICBlbmQgZnVuY3Rpb24gZnVuYzIKCiAgZnVuY3Rp b24gZnVuYygpIHJlc3VsdChhKQogICAgY2xhc3MocCksIGFsbG9jYXRhYmxlIDo6IGEoOikK CiAgICBhID0gW2MoKSxjKCksYygpXQogICAgc2VsZWN0IHR5cGUoYSkKICAgIHR5cGUgaXMg KGMpCiAgICAgIGEoMSklc3RyID0gJ2FiY2QnCiAgICAgIGEoMiklc3RyID0gJ2FiYycKICAg ICAgYSgzKSVzdHIgPSAnYWJjZDQnCiAgICAgIGEoMSklc3RyMiA9IFsnYWJjZCcsJ2VmZ2gn XQogICAgICBhKDIpJXN0cjIgPSBbJ2JjZCcsJ2ZnaCddCiAgICAgIGEoMyklc3RyMiA9IFsn YWJjZDYnLCdlZmdoNyddCiAgICBlbmQgc2VsZWN0CiAgZW5kIGZ1bmN0aW9uIGZ1bmMKZW5k IHByb2dyYW0K --------------jZkim699WKTV5MBcugHQNrju--